Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WRN_PartialMethodTypeDifference to warning wave #52520

Closed
Youssef1313 opened this issue Apr 9, 2021 · 4 comments · Fixed by #53352
Closed

Add WRN_PartialMethodTypeDifference to warning wave #52520

Youssef1313 opened this issue Apr 9, 2021 · 4 comments · Fixed by #53352
Labels
Area-Compilers Bug
Milestone
C# 10

Comments

@Youssef1313
Copy link
Member

#47879 indicates that this should have been added in 16.9, but it was missed.

Related to #47841 and #47879

@jaredpar @cston Can this be added now to warning level 5 or is it too late? I don't know what your policy is for adding new warnings to warning waves.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 9, 2021
@Youssef1313 Youssef1313 changed the title Add WRN_PartialMethodTypeDifference to warning level Add WRN_PartialMethodTypeDifference to warning wave Apr 9, 2021
@jaredpar
Copy link
Member

jaredpar commented Apr 9, 2021

At this point it would need to be in a new warning wave. The current wave is essentially locked.

Not a huge deal though. We're doing a new wave with ever language version so it can just tack into the new one.

@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 9, 2021
@jaredpar jaredpar added this to the C# 10 milestone Apr 9, 2021
@RikkiGibson
Copy link
Contributor

To be clear, this is something we'd now like to do in wave 6, right?

@Youssef1313
Copy link
Member Author

To be clear, this is something we'd now like to do in wave 6, right?

Yes.

@jaredpar Is this something that can go into features/compiler branch now?

@Youssef1313 Youssef1313 mentioned this issue May 12, 2021
Merged
@Youssef1313
Copy link
Member Author

Closing. Fixed in #53352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug
Projects
None yet
Milestone
C# 10
Development

Successfully merging a pull request may close this issue.

Revert "Revert "Require partial method signatures to match" (47576) (#47879)" Youssef1313/roslyn
3 participants
@jaredpar @RikkiGibson @Youssef1313