Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review use of SyntheticBoundNodeFactory.Block() to ensure expected syntax is used #53019

Open
cston opened this issue Apr 29, 2021 · 0 comments · May be fixed by #59236
Open

Review use of SyntheticBoundNodeFactory.Block() to ensure expected syntax is used #53019

cston opened this issue Apr 29, 2021 · 0 comments · May be fixed by #59236
Labels
Area-Compilers Bug
Milestone
Backlog

Comments

@cston
Copy link
Member

cston commented Apr 29, 2021

It feels like we need to check other usages of this API and its overloads that pull syntax from the factory. Perhaps, we should add explicit syntax parameter to all of them, to make sure an explicit decision is made about syntax at each call site.

Originally posted by @AlekseyTs in #52987 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 29, 2021
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 13, 2021
@jaredpar jaredpar added this to the 17.0 milestone Jul 13, 2021
@cston cston modified the milestones: 17.0, 17.1 Sep 2, 2021
@cston cston linked a pull request Feb 3, 2022 that will close this issue
Draft
@cston cston modified the milestones: 17.1, Compiler.Next Feb 17, 2022
@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Save and restore '_factory.Syntax' in LocalRewriter methods cston/roslyn
2 participants
@jaredpar @cston