Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sig info, error message formatting when working with complex generic code #53061

Closed
tmat opened this issue Apr 30, 2021 · 4 comments · Fixed by #56025
Closed

Improve sig info, error message formatting when working with complex generic code #53061

tmat opened this issue Apr 30, 2021 · 4 comments · Fixed by #56025
Labels
Area-IDE Concept-Continuous Improvement Need Design Review The end user experience design needs to be reviewed and approved.
Milestone

Comments

@tmat
Copy link
Member

tmat commented Apr 30, 2021

Working with types that combine generics and tuples is cumbersome. The IDE does not help much at all.

using var _ = PooledDictionary<string, ArrayBuilder<(ManagedActiveStatementDebugInfo info, SourceFileSpan span, int ordinal)>>.GetInstance(out var updatedSpansByDocumentPath);

var x = updatedSpansByDocumentPath.ToImmutableDictionary(
     keySelector: 

Can we structure the signatures better using line breaks and indentation?

Sig info:
image

Hover:
image

Types in diagnostic not colorized and the error is hard to read with the long type names in the middle of the error message:
image

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 30, 2021
@Youssef1313
Copy link
Member

Youssef1313 commented Apr 30, 2021

Related to #29949 and #33609.

@jinujoseph jinujoseph added Need Design Review The end user experience design needs to be reviewed and approved. Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels May 5, 2021
@jinujoseph jinujoseph added this to the Backlog milestone May 5, 2021
@jinujoseph
Copy link
Contributor

Need a proposal before bringing to design meeting

@DoctorKrolic
Copy link
Contributor

@CyrusNajmabadi You fixed this issue in #56025, so it should be closed now

@CyrusNajmabadi
Copy link
Member

Works for me. Thanks!

@sharwell sharwell moved this to Need Proposal in IDE: Design review Aug 22, 2023
@CyrusNajmabadi CyrusNajmabadi moved this from Need Proposal to Complete in IDE: Design review Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement Need Design Review The end user experience design needs to be reviewed and approved.
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

5 participants