Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArPow] Run source-build leg in official builds #53764

Closed
MichaelSimons opened this issue May 28, 2021 · 8 comments · Fixed by #54009
Closed

[ArPow] Run source-build leg in official builds #53764

MichaelSimons opened this issue May 28, 2021 · 8 comments · Fixed by #54009
Assignees
Milestone

Comments

@MichaelSimons
Copy link
Member

This is required in order to publish the Microsoft.SourceBuild.Intermediate.roslyn NuGet package so that it can be referenced by downstream dependent repos that participate in source-build.

ArPow CI onboarding describes what Arcade templates exist to support this.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 28, 2021
@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 1, 2021
@jinujoseph jinujoseph added this to the 17.0 milestone Jun 1, 2021
@MichaelSimons
Copy link
Member Author

@JoeRobich - This is blocking the ArPow work, can this get fixed before .NET Preview 6 release branch snap and build which starts on 15-Jun?

@RikkiGibson
Copy link
Contributor

Is this referring to the same thing as the source build leg that we already run in roslyn-ci?

@MichaelSimons
Copy link
Member Author

Yes, the source build leg that is run in PR validation should get run in the internal ci / official builds and the resulting Microsoft.SourceBuild.Intermediate NuGet package needs to get published to BAR. The source-build template should handle all of this.

@JoeRobich
Copy link
Member

@MichaelSimons Does this build give you what you need? If so then we can move forward with PR #54009

@JoeRobich
Copy link
Member

@MichaelSimons It helps if I link to the build - https://dev.azure.com/dnceng/internal/_build/results?buildId=1182202&view=results

@MichaelSimons
Copy link
Member Author

Yep that looks correct, thanks. The only thing to verify with a full build is that the Microsoft.SourceBuild.Intermediate.roslyn..nupkg that gets produced in the source-build leg gets published to BAR.

@JoeRobich
Copy link
Member

Reopening until we confirmed publishing

@MichaelSimons
Copy link
Member Author

I verified the Microsoft.SourceBuild.Intermediate.roslyn..nupkg is now getting published to BAR by the official builds. Thanks @JoeRobich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants