Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Responsiveness] ChecksumCollection.FindAsync excessively allocates during solution open (1.8%/765 MB during solution open) #54436

Closed
davkean opened this issue Jun 28, 2021 · 4 comments
Closed

[Responsiveness] ChecksumCollection.FindAsync excessively allocates during solution open (1.8%/765 MB during solution open) #54436

davkean opened this issue Jun 28, 2021 · 4 comments
Labels
Area-IDE Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
17.0.P2

Comments

@davkean
Copy link
Member

davkean commented Jun 28, 2021

Version Used:
Version: 17.0.0 Preview 2.0 [31422.448.main]

Trace (936 projects Orchard Core hybrid)

Can we unroll LINQ and see if we can avoid boxing the enumerators?

Callees:
image

Callers:
image
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 28, 2021
@sharwell
Copy link
Member

Already fixed by #53959

@sharwell sharwell added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Jun 29, 2021
@sharwell sharwell added this to the Next milestone Jun 29, 2021
@sharwell sharwell removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 29, 2021
@davkean
Copy link
Member Author

davkean commented Jun 29, 2021

@sharwell This is based on 17.0.0 Preview 2.0 [31422.448.main], what build will this get into?

@sharwell
Copy link
Member

I'm not sure what 31422.448.main is, but if you have a commit hash from Help→About I can verify that the fix was not yet included for the test.

@davkean
Copy link
Member Author

davkean commented Jun 29, 2021

I only have a trace unfortunately.

@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
17.0.P2
Development

No branches or pull requests
3 participants
@davkean @sharwell @RikkiGibson