Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming/changing arity of a reloadable type is not handled correctly #54881

Open
tmat opened this issue Jul 16, 2021 · 0 comments
Open

Renaming/changing arity of a reloadable type is not handled correctly #54881

tmat opened this issue Jul 16, 2021 · 0 comments

Comments

@tmat
Copy link
Member

tmat commented Jul 16, 2021

The general problem is that we use symbol keys to resolve symbols between old and new compilation on some code paths in the semantic analysis.
A type that is renamed or whose arity is changed does not resolve anymore. This is not a problem for regular types since their rename/arity change is a rude edit, but for reloadable types these operations should be allowed and result in a new type.

The solution would be to process symbol renames first and then apply the mapping to the symbol key resolution so that the resolution can find the symbol using its previous name.

Related: #54886

See skipped tests.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 16, 2021
@tmat tmat added Interactive-EnC and removed Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 16, 2021
@tmat tmat added this to the 17.0 milestone Jul 16, 2021
@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Sep 27, 2021
@tmat tmat modified the milestones: 17.1, Backlog Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants