Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiagnosticAnalyzer implementations need a syntax filter to exclude their overhead from unrelated light bulbs #55228

Closed
3 tasks
sharwell opened this issue Jul 29, 2021 · 1 comment
Closed
3 tasks

DiagnosticAnalyzer implementations need a syntax filter to exclude their overhead from unrelated light bulbs #55228

sharwell opened this issue Jul 29, 2021 · 1 comment
Assignees
@mavasani
Labels
Area-IDE Area-Performance Bug Performance-Scenario-Diagnostics This issue affects diagnostics computation performance for lightbulb, background analysis, tagger. Tenet-Performance Regression in measured performance of the product from goals.
Milestone
17.6 P2

Comments

@sharwell
Copy link
Member

sharwell commented Jul 29, 2021 •
edited
Loading

Version Used: 17.0.0-preview-3.0-[31527.483.main]

Steps to Reproduce:

  1. On a line which does not contain a cast (or a suppression for a cast), press Ctrl+.

Expected Behavior:

The Remove Unnecessary Cast analyzer does not execute as part of calculating the light bulb.

Actual Behavior:

The Remove Unnecessary Cast analyzer runs as part of calculating the light bulb, but will never offer any suggestions. This calculation delays the operations which are included.

List of top-hitting analyzers for this:

  • Remove unnecessary suppression (only needs to run on a line with a suppression)
  • Remove unnecessary cast (only needs to run on a line with a cast)
  • Simplify type name (only needs to run if the error list is currently showing a Simplify Type Name diagnostic on the current line)
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 29, 2021
@jinujoseph jinujoseph added Area-Performance and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 6, 2021
@jinujoseph jinujoseph added this to the 17.0 milestone Aug 6, 2021
@sharwell sharwell assigned mavasani and unassigned sharwell Sep 21, 2021
@sharwell sharwell modified the milestones: 17.0, 17.1 Sep 21, 2021
@jmarolf jmarolf added the User Story A single user-facing feature. Can be grouped under an epic. label Dec 2, 2021
@sharwell sharwell mentioned this issue Dec 20, 2021
Closed
@jmarolf jmarolf removed the User Story A single user-facing feature. Can be grouped under an epic. label Jan 6, 2022
@mavasani mavasani modified the milestones: 17.1, 17.2 Jan 10, 2022
@jinujoseph jinujoseph modified the milestones: 17.2, 17.3 May 5, 2022
@mavasani mavasani added the Tenet-Performance Regression in measured performance of the product from goals. label Oct 7, 2022
@arunchndr arunchndr modified the milestones: 17.3, 17.6 P2 Jan 17, 2023
@mavasani mavasani mentioned this issue Apr 6, 2023
Closed
@mavasani mavasani added the Performance-Scenario-Diagnostics This issue affects diagnostics computation performance for lightbulb, background analysis, tagger. label May 1, 2023
@mavasani
Copy link
Contributor

mavasani commented Jan 3, 2024

This has been completed

@mavasani mavasani closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-IDE Area-Performance Bug Performance-Scenario-Diagnostics This issue affects diagnostics computation performance for lightbulb, background analysis, tagger. Tenet-Performance Regression in measured performance of the product from goals.
Projects
None yet
Milestone
17.6 P2
Development

No branches or pull requests
5 participants
@sharwell @jmarolf @mavasani @jinujoseph @arunchndr