Timeout on Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests.dll tests

[dibarbet]

Rolling builds a relatively frequently timing out on this helix work item.

From helix log

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:13:35.51]     Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Interactive.Commands.InteractiveCommandHandlerTests.TestExecuteInInteractiveWithDefines [SKIP]
  Skipped Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Interactive.Commands.InteractiveCommandHandlerTests.TestExecuteInInteractiveWithDefines [1 ms]
['Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests.dll' END OF WORK ITEM LOG: Command timed out, and was killed]

Build	Kind	Console
1814569	Rolling	console.log

[vatsalyaagrawal]

Adding Sam's feedback: We need a heap dump at the time of timeout. We already call dotnet test so we just need to add --blame-hang to it

[JoeRobich]

Test runner command line args are generated in https://github.com/dotnet/roslyn/blob/main/src/Tools/Source/RunTests/ProcessTestExecutor.cs#L30

[jasonmalinowski]

#57549 should hopefully add a dump.

[jasonmalinowski]

#57549 has been merged; it's possible that runfo will no longer update this bug with hits that includes a dump, because the message has changed.

[jcouv]

@allisonchou From comments above it sounds like this issue might have been fixed already. Could you confirm and close if so? Thanks

[jcouv]

Chatted with Jared. He expected those helix time-outs would result in crash dumps (which we could investigate). But it looks like crash dumps are not getting produced, most likely because we run tests with a longer time-out than helix. Thread was started to clarify this time-out issue.

[jcouv]

The timeout was adjusted, so hopefully we should start seeing some crash dumps for this issue.

[CyrusNajmabadi]

Closing due to lack of movement.

[CyrusNajmabadi]

Reopening for TestExecuteInInteractiveWithDefines