Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnC - Relax restrictions on record parameter names matching #55732

Closed
davidwengier opened this issue Aug 19, 2021 · 0 comments · Fixed by #55739
Closed

EnC - Relax restrictions on record parameter names matching #55732

davidwengier opened this issue Aug 19, 2021 · 0 comments · Fixed by #55739
Assignees
@davidwengier
Labels
Area-Compilers Concept-Continuous Improvement Interactive-EnC Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
17.0

Comments

@davidwengier
Copy link
Contributor

Currently we report rude edits when explicitly implementing members of records that are normally synthesized, if the parameter names don't match what the compiler would synthesize. Since we now allow renaming parameters we no longer need this limit, as the symbol matcher ignores parameter names.

We shouldn't need to worry about capabilities here I don't think.

Code to be removed is marked with a reference to #52563 in source.
@davidwengier davidwengier added this to the 17.0 milestone Aug 19, 2021
@davidwengier davidwengier self-assigned this Aug 19, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 19, 2021
This was referenced Aug 19, 2021
Merged
Merged
@jinujoseph jinujoseph added Concept-Continuous Improvement Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
Area-Compilers Concept-Continuous Improvement Interactive-EnC Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
17.0
Development

Successfully merging a pull request may close this issue.

EnC - Allow changing names of previously synthesized record member parameters davidwengier/roslyn
2 participants
@davidwengier @jinujoseph