-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update snippets to use modern language features (eg "nameof") #5574
Comments
As with #3469, we should probably do a sweep through all snippets. One consideration from the past is whether we realistically expect customers to use these snippets in scenarios where they would set their "langversion" switch back, since we don't have a mechanism to do different things in snippets. |
This snippet is actually one of the worst from the very beginning. Apart from
plus my personal preferences do not improve it,
(and snippets for read-only DP and attached DP are missing completely) As for "langversion", snippets has Could perhaps the snippets be put on GitHub or somewhere were people could contribute to them? |
Blocked on #31879 |
The classname issue is mentioned in https://stackoverflow.com/q/35410712/3195477 which also proposes a workaround. |
Snippets are being entirely revamped. So we're unlikely to update these snippets. |
@CyrusNajmabadi Can you clarify what additional info is needed? |
Need more info on if we're actually intending on giving these snippets a future. |
Ah, sounds like the triage was already correct on this issue (blocked on a linked issue). I moved the issue to backlog and it can be handled as a follow-up to the blocking issue. |
AFAICT, legacy snippets have no future and are not being maintained at all. Semantic snippets are the only place we're investing in. Closing out as out of scope for roslyn now. |
The "propdp" snippet spits out a dependency property. I think it should spit out the
nameof(.)
operator, rather than spitting out a text literal.The text was updated successfully, but these errors were encountered: