Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected formatting warning for a space between a new modifier and a tuple type syntax. #56498

Closed
AlekseyTs opened this issue Sep 17, 2021 · 2 comments · Fixed by #58810
Closed

Unexpected formatting warning for a space between a new modifier and a tuple type syntax. #56498

AlekseyTs opened this issue Sep 17, 2021 · 2 comments · Fixed by #58810
Assignees
@jcouv
Labels
Area-IDE Blocked Concept-Continuous Improvement IDE-Formatter Code formatter and/or smart indent
Milestone
17.1

Comments

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Sep 17, 2021 •
edited by jcouv
Loading

Microsoft Visual Studio Enterprise 2022 Int Preview (64-bit)
Version 17.0.0 Preview 5.0 [31713.378.main]

image

The warning goes away if the space is removed:
image

Expected: No warning when the space is present, a warning when it is missing.

Note: this issue is referenced in source.
@AlekseyTs AlekseyTs added the IDE-CodeStyle Built-in analyzers, fixes, and refactorings label Sep 17, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 17, 2021
@sharwell sharwell added Area-IDE IDE-Formatter Code formatter and/or smart indent and removed Area-Compilers IDE-CodeStyle Built-in analyzers, fixes, and refactorings labels Sep 20, 2021
@jcouv jcouv self-assigned this Sep 20, 2021
@jcouv jcouv mentioned this issue Sep 20, 2021
Merged
@jcouv
Copy link
Member

jcouv commented Sep 22, 2021

The codestyle analyzer was fixed. Once we consume an updated package, the reference in code can be removed.

@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 22, 2021
@jinujoseph jinujoseph added this to the 17.1 milestone Sep 22, 2021
@jinujoseph
Copy link
Contributor

blocked on 17.0 rtm

This was referenced Jan 10, 2022
Merged
Merged
@jcouv jcouv moved this to Active/Investigating in Compiler: Julien's umbrellas Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
Area-IDE Blocked Concept-Continuous Improvement IDE-Formatter Code formatter and/or smart indent
Projects
Compiler: Julien's umbrellas
Archived in project
Milestone
17.1
Development

Successfully merging a pull request may close this issue.

Remove formatting suppression for tuple syntax jcouv/roslyn
4 participants
@sharwell @AlekseyTs @jinujoseph @jcouv