Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConvertNamespaceCommandHandler performs an unexpected Format Document operation #58078

Closed
sharwell opened this issue Dec 2, 2021 · 0 comments · Fixed by #58434
Closed

ConvertNamespaceCommandHandler performs an unexpected Format Document operation #58078

sharwell opened this issue Dec 2, 2021 · 0 comments · Fixed by #58434
Assignees
@CyrusNajmabadi
Labels
Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality help wanted The issue is "up for grabs" - add a comment if you are interested in working on it

Comments

@sharwell
Copy link
Member

sharwell commented Dec 2, 2021 •
edited
Loading

❗ This assumes the file is formatted according to the formatter, which is not a safe (or necessary) assumption. This feature is only allowed to remove a uniform number of leading spaces from each line in the namespace block, and is not allowed to force potentially incorrect formatting throughout the file.

Originally posted by @sharwell in #58003 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 2, 2021
@sharwell sharwell added Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality and removed Bug labels Dec 2, 2021
@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 9, 2021
@jinujoseph jinujoseph added this to the 17.1 milestone Dec 9, 2021
@CyrusNajmabadi CyrusNajmabadi modified the milestones: 17.1, 17.2 Dec 15, 2021
@CyrusNajmabadi CyrusNajmabadi mentioned this issue Dec 20, 2021
Merged
@Youssef1313 Youssef1313 mentioned this issue Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update 'convert namespace' to only 'dedent' file contents, not format them. CyrusNajmabadi/roslyn
4 participants
@davidwengier @sharwell @CyrusNajmabadi @jinujoseph