Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindAllReferences on Length property or Slice method misses usages in list-patterns #58190

Closed
jcouv opened this issue Dec 8, 2021 · 2 comments

Comments

@jcouv
Copy link
Member

jcouv commented Dec 8, 2021

FAR doesn't understand properties/indexers/methods that are used in list-patterns yet.

_ = new Collection() is [1, 2];
class Collection
{
   public int Length => 0;
   public object this[int i] => null;
   public Collection Slice(int i, int j) => null;
}

Relates to test plan #51289

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 8, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 8, 2021
@jinujoseph jinujoseph added this to the 17.1 milestone Dec 8, 2021
@CyrusNajmabadi CyrusNajmabadi modified the milestones: 17.1, 17.2 Dec 15, 2021
@CyrusNajmabadi
Copy link
Member

Moving out of 17.1 we def don't need this immediately. Note: this would be a good way for someone to learn how to update FAR/indices.

@jinujoseph jinujoseph modified the milestones: 17.2, 17.3 May 5, 2022
@arunchndr arunchndr modified the milestones: 17.3, 17.6 P2 Jan 17, 2023
@arunchndr arunchndr modified the milestones: 17.6 P2, Backlog Oct 29, 2024
@CyrusNajmabadi
Copy link
Member

Closing out due to lack of feedback. It's also unclear if there's an api to even solve this with.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants