Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param-nullchecking doesn't work properly with formatting analyzer #58798

Closed
RikkiGibson opened this issue Jan 12, 2022 · 1 comment · Fixed by #58936
Closed

Param-nullchecking doesn't work properly with formatting analyzer #58798

RikkiGibson opened this issue Jan 12, 2022 · 1 comment · Fixed by #58936

Comments

@RikkiGibson
Copy link
Contributor

Version Used: f29f937

Steps to Reproduce:

Change this method to the following:

        /// <summary>
        /// A rope can wrap a simple string.
        /// </summary>
        public static Rope ForString(string s!!)
        {
            return new StringRope(s);
        }

Expected Behavior: No "fix formatting" warning is given

Actual Behavior: "Fix formatting" warning is given, and the suggested fix appears to be empty

image

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 12, 2022
@RikkiGibson RikkiGibson self-assigned this Jan 12, 2022
@RikkiGibson RikkiGibson added Feature - Param Null Checking and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 12, 2022
@RikkiGibson RikkiGibson added this to the 17.2 milestone Jan 12, 2022
@RikkiGibson
Copy link
Contributor Author

I think the issue here is that an old version of the formatting analyzer is used here, instead of the one used in the SDK or the one used during the build (i.e. in Build.cmd -deployExtensions -launch scenario).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant