Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OptionKey serializable so that integration tests can pass it between processes #59267

Closed
Tracked by #58717
tmat opened this issue Feb 4, 2022 · 2 comments
Closed
Tracked by #58717

Make OptionKey serializable so that integration tests can pass it between processes #59267

tmat opened this issue Feb 4, 2022 · 2 comments
Assignees
@tmat
Labels
Area-IDE Concept-Continuous Improvement

Comments

@tmat
Copy link
Member

tmat commented Feb 4, 2022

Tracks TODO in WellKnownGlobalOptions.cs
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 4, 2022
@tmat tmat added Concept-Continuous Improvement and removed Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 4, 2022
@tmat tmat self-assigned this Feb 4, 2022
@tmat tmat added the Area-IDE label Feb 4, 2022
@tmat tmat mentioned this issue Feb 4, 2022
Closed
73 tasks
@sharwell
Copy link
Member

sharwell commented Feb 4, 2022

This is not necessary. Only the legacy integration tests suffer from this issue and the new integration tests already support OptionKey.

@tmat
Copy link
Member Author

tmat commented Feb 4, 2022

Cool. Let's just move the tests over then.

@tmat tmat closed this as completed May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmat tmat

Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmat @sharwell