Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behaviour with async method declaration: wrong types suggestion #60341

Closed
DoctorKrolic opened this issue Mar 23, 2022 · 2 comments · Fixed by #60528
Closed

Odd behaviour with async method declaration: wrong types suggestion #60341

DoctorKrolic opened this issue Mar 23, 2022 · 2 comments · Fixed by #60528
Assignees
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug
Milestone

Comments

@DoctorKrolic
Copy link
Contributor

Probably related to #60339

Version Used:
VS 2022 v.17.2 Preview 2.1

Steps to Reproduce:
Start code:

class Test
{
    public async $$
}

Expected Behavior:
Only Task, Task<>, ValueTask and ValueTask<> are suggested

Actual Behavior:
devenv_VObHb5szpa

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 23, 2022
@CyrusNajmabadi
Copy link
Member

This would be a reasonable thing to filter down to. Note: we would want any type with [AsyncMethodBuilder] on it.

@jinujoseph jinujoseph added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 30, 2022
@jinujoseph jinujoseph added this to the 17.3 milestone Mar 30, 2022
@sharwell
Copy link
Member

sharwell commented Mar 30, 2022

@CyrusNajmabadi If you put [AsyncMethodBuilder] on the method itself, does it allow any type or only awaitable types?

See also #54033

@jinujoseph jinujoseph added the Need More Info The issue needs more information to proceed. label Mar 30, 2022
@ghost ghost added untriaged Issues and PRs which have not yet been triaged by a lead and removed Need More Info The issue needs more information to proceed. labels Mar 30, 2022
@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 5, 2022
@jinujoseph jinujoseph added the 4 - In Review A fix for the issue is submitted for review. label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants