Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonSerializable Attribute Causing CS1591 Error #60533

Closed
RealDotNetDave opened this issue Apr 1, 2022 · 4 comments
Closed

JsonSerializable Attribute Causing CS1591 Error #60533

RealDotNetDave opened this issue Apr 1, 2022 · 4 comments
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@RealDotNetDave
Copy link

After applying the JsonSerializable attribute to a class, the build failed with this error:

CS1591: Missing XML comment for publicly visible type or member 'PersonProperJsonSerializerContext.DateTimeOffset'

I have tried using the SupressMessage attribute to get it to build, but that does not work.

I am using .NET 6 and Visual Studio 17.1.2.

@mavasani mavasani transferred this issue from dotnet/roslyn-analyzers Apr 2, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 2, 2022
@jcouv
Copy link
Member

jcouv commented Apr 3, 2022

@RealDotNetDave Do you have a way to reproduce the problem on a standalone/simple project by any chance? It's hard to tell what's going on from your description and I'm not seeing an obvious indication that the compiler is doing anything wrong.

@Youssef1313
Copy link
Member

@jcouv I think the generator is doing something wrong. It doesn't generate documentation comments for public members, so the compiler issues a diagnostic.

I'd close this as a duplicate of dotnet/runtime#61379.

@Youssef1313
Copy link
Member

Also related to #54119

@jcouv
Copy link
Member

jcouv commented Apr 5, 2022

Thanks. Closing as duplicate of #54119. Will add a note there too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

No branches or pull requests

3 participants