Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ILegacyGlobalCleanCodeGenerationOptionsWorkspaceService #60786

Open
Tracked by #58717
, #60803
...
tmat opened this issue Apr 15, 2022 · 0 comments
Open
Tracked by #58717
, #60803
...

Remove ILegacyGlobalCleanCodeGenerationOptionsWorkspaceService #60786

tmat opened this issue Apr 15, 2022 · 0 comments
Labels
Area-IDE Concept-Continuous Improvement
Milestone
Backlog

Comments

@tmat
Copy link
Member

tmat commented Apr 15, 2022 •
edited
Loading

Tracks TODO in source.

Currently using ILegacyGlobalCleanCodeGenerationOptionsWorkspaceService as a workaround in:

  • AbstractMemberInsertingCompletionProvider.GetChangeAsync
  • AbstractImportCompletionProvider.GetChangeAsync
  • CodeAction.PostProcessChangesAsync

Remove this interface once fallback options are properly passed to the above code.
@tmat tmat self-assigned this Apr 15, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 15, 2022
This was referenced Apr 17, 2022
Closed
Merged
Closed
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 19, 2022
@jinujoseph jinujoseph added this to the 17.3 milestone Apr 19, 2022
@arunchndr arunchndr modified the milestones: 17.3, 17.4 Oct 3, 2022
@arunchndr arunchndr modified the milestones: 17.4, 17.6 P3 Jan 17, 2023
@tmat tmat modified the milestones: 17.6 P3, Next Feb 9, 2023
@tmat tmat removed their assignment Feb 9, 2023
@tmat tmat changed the title CompletionProvider.GetChangeAsync needs fallback options Remove ILegacyGlobalCodeActionOptionsWorkspaceService Feb 9, 2023
@tmat tmat changed the title Remove ILegacyGlobalCodeActionOptionsWorkspaceService Remove ILegacyGlobalCleanCodeGenerationOptionsWorkspaceService Feb 10, 2023
@tmat tmat mentioned this issue Feb 10, 2023
Open
@arunchndr arunchndr modified the milestones: Next, 17.9 Sep 12, 2023
@tmat tmat modified the milestones: 17.9, Backlog May 29, 2024
@tmat tmat mentioned this issue Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@tmat @jinujoseph @arunchndr