Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit usage of global SimplifierOptions in IBuiltInAnalyzer.OpenFileOnly #60795

Closed
Tracked by #58717
, #60803
...
tmat opened this issue Apr 16, 2022 · 2 comments
Closed
Tracked by #58717
, #60803
...

Revisit usage of global SimplifierOptions in IBuiltInAnalyzer.OpenFileOnly #60795

tmat opened this issue Apr 16, 2022 · 2 comments
Assignees
@tmat
Labels
Area-Analyzers Concept-Continuous Improvement
Milestone
17.6 P3

Comments

@tmat
Copy link
Member

tmat commented Apr 16, 2022 •
edited
Loading

Some built-in analyzers declare themselves as "open file only" (IsOpenFileOnly) when certain code style options have certain severity.

The decision is made based on Solution-wide IDE options, not based on values of these options in editorconfig.
Is this correct?

See IBuiltinAnalyzer.IsOpenFileOnly and CompilationHasOpenFileOnlyAnalyzers
@tmat tmat self-assigned this Apr 16, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 16, 2022
@tmat tmat changed the title Revisit usage of global SimplifierOptions in DiagnosticIncrementalAnalyzer.Executor.TryReduceAnalyzersToRun Revisit usage of global SimplifierOptions in analyzer executor Apr 16, 2022
@tmat tmat changed the title Revisit usage of global SimplifierOptions in analyzer executor Revisit usage of global SimplifierOptions in IBuiltinAnalyzer.IsOpenFileOnly Apr 16, 2022
@tmat tmat changed the title Revisit usage of global SimplifierOptions in IBuiltinAnalyzer.IsOpenFileOnly Revisit usage of global SimplifierOptions in IBuiltInAnalyzer.OpenFileOnly Apr 16, 2022
This was referenced Apr 17, 2022
Closed
Merged
Closed
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 19, 2022
@jinujoseph jinujoseph added this to the 17.3 milestone Apr 19, 2022
@tmat
Copy link
Member Author

tmat commented Apr 25, 2022

#26758

@arunchndr arunchndr modified the milestones: 17.3, 17.4 Oct 3, 2022
@arunchndr arunchndr modified the milestones: 17.4, 17.6 P3 Jan 17, 2023
@CyrusNajmabadi
Copy link
Member

IBuiltInAnalyzer.OpenFileOnly was removed.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmat tmat

Labels
Area-Analyzers Concept-Continuous Improvement
Projects
None yet
Milestone
17.6 P3
Development

No branches or pull requests
4 participants
@tmat @CyrusNajmabadi @jinujoseph @arunchndr