Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyRefAssembly task should log the file copy #61383

Closed
KirillOsenkov opened this issue May 18, 2022 · 3 comments · Fixed by #61384
Closed

CopyRefAssembly task should log the file copy #61383

KirillOsenkov opened this issue May 18, 2022 · 3 comments · Fixed by #61384
Assignees
Labels
Area-Compilers Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. Feature Request
Milestone

Comments

@KirillOsenkov
Copy link
Member

If the CopyRefAssembly task finds that the destination .dll has the same MVID as the source, it will helpfully log a message that the copy is skipped:

Log.LogMessageFromResources(MessageImportance.Low, "CopyRefAssembly_SkippingCopy1", DestinationPath);

However if it proceeds to copy the file over, it doesn't seem to log the message.

It would help for various analysis tools if it logged the same message as the MSBuild Copy task in case the file is copied:
"Copying ... to ..."
https://github.com/dotnet/msbuild/blob/e049bfe3dddb84270dec5fc1aaedc9664f77eb98/src/Tasks/Copy.cs#L303

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label May 18, 2022
@KirillOsenkov
Copy link
Member Author

Ideally also log another, diag-level message that would print the source MVID and the destination MVID in case they were different, as well as the timestamp on both source and destination. This would be incredibly valuable for incremental build investigations.

@jcouv
Copy link
Member

jcouv commented May 18, 2022

Thanks for the feedback. Will take a look and tag you on PR.

@jcouv jcouv added Feature Request Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. and removed untriaged Issues and PRs which have not yet been triaged by a lead labels May 18, 2022
@jcouv jcouv added this to the 17.3 milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants