Revise CompilerGeneratedAttribute behavior when records are inherited

[Youssef1313]

using System;
using System.Linq;

var hashCodeAttributes = typeof(RR).GetMethod("GetHashCode").GetCustomAttributes(inherit: true);
// prints: "System.Runtime.CompilerServices.CompilerGeneratedAttribute"
// It prints "No attributes" if `inherit: true` is changed to `false`.
Console.WriteLine(hashCodeAttributes.Length == 0 ? "No attributes" : hashCodeAttributes.Single());

record R
{
}

record RR : R
{
    public override int GetHashCode()
    {
        return 0;
    }
}

Is this behavior okay? @jcouv

[jcouv]

I think that's okay. CompilerGeneratedAttribute has Inherited=true, so when using the GetCustomAttributes API with inherit: true option, it will show up.

[System.AttributeUsage(System.AttributeTargets.All, Inherited=true)]
public sealed class CompilerGeneratedAttribute : Attribute

[Youssef1313]

@jcouv So it seems #58542 (comment) no longer holds. So should we move the attribute back to the property instead of accessors?

[jcouv]

@Youssef1313 That would make sense. I hadn't connected those dots.