Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LSP] Remove NFW reporting in RangeToTextSpan after issue is fixed #66258

Closed
allisonchou opened this issue Jan 5, 2023 · 2 comments
Closed

[LSP] Remove NFW reporting in RangeToTextSpan after issue is fixed #66258

allisonchou opened this issue Jan 5, 2023 · 2 comments
Assignees
@beccamc
Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation
Milestone
17.6

Comments

@allisonchou
Copy link
Contributor

We are adding additional NFW reporting in RangeToTextSpan in order to diagnose the exception found in this issue (MSFT internal). It should no longer be needed in this location after the underlying issue is resolved.
@allisonchou allisonchou added Area-IDE LSP issues related to the roslyn language server protocol implementation labels Jan 5, 2023
@allisonchou allisonchou self-assigned this Jan 5, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 5, 2023
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 6, 2023
@arunchndr arunchndr added this to the 17.6 milestone Jan 6, 2023
@beccamc beccamc mentioned this issue May 3, 2023
Merged
@beccamc
Copy link
Contributor

beccamc commented May 11, 2023

Also remove the code from 0d26c35

@beccamc beccamc assigned beccamc and unassigned allisonchou May 11, 2023
@beccamc
Copy link
Contributor

beccamc commented Dec 19, 2023

David and I agreed the custom logging is useful. Closing.

@beccamc beccamc closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beccamc beccamc

Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
17.6
Development

No branches or pull requests
3 participants
@beccamc @allisonchou @arunchndr