Closing a document brings back stale diagnostics

[sharwell]

Version Used:

• Analysis scope set to Open Documents via solution explorer
• LSP pull diagnostics enabled

Steps to Reproduce:

1. Introduce a build warning
2. Build the project
3. Open the document with the build warning
4. Fix the build warning
5. Close the document with the build warning

Expected Behavior:

• After step (2), the warning appears in the error list
• After step (4), the warning disappears from the error list

Actual Behavior:

• After step (2), the warning appears in the error list
• After step (4), the warning disappears from the error list
• After step (5), the warning reappears in the error list

[CyrusNajmabadi]

@AmadeusW @kayle

[kayle]

What would you expect if you close the file in step 5 without saving?

[CyrusNajmabadi]

What would you expect if you close the file in step 5 without saving?

the diagnostic would be gone. you'd have to rebuild to get it again. we don't track the impacts of mutations (it's nearly impossible, since any change anywhere can have impacts on diagnostics everywhere).

so you might change code in a different file which fixes the diag in this file, save it, then not save this file that contains the diagnostic. That shouldn't bring the diagnostic back.

This is the experience in roslyn today, and it's fine. Things always move forward. Builds represent results for an event in the past. And even if varying changes happen (or get tossed) past that point, it still represents the past, and may have to to be rerun to represent the present.

[kayle]

The latest dogfooding build should now match the expected behavior.

[CyrusNajmabadi]

Thanks @kayle !

[mavasani]

@kayle @CyrusNajmabadi The original issue described by @sharwell seems to be fixed in the latest build. However, I am seeing duplicate and stale diagnostics with Full solution analysis enabled. See the repro below:

[kayle]

Thanks @mavasani - I can fix that issue.

What do you expect after closing the document? Currently the warning will go away until the next workspace request regenerates it.

[CyrusNajmabadi]

Currently the warning will go away until the next workspace request regenerates it.

That is my expectation. "Latest wins". So the document superseded the workspace. Until workspace runs again, the warning will be gone.

[CyrusNajmabadi]

@kayle can you link to your PR for this? I'd like to close this out. Thanks!

[kayle]

https://devdiv.visualstudio.com/DevDiv/_git/VS-Platform/pullrequest/503146?_a=files

[CyrusNajmabadi]

Fixed with https://devdiv.visualstudio.com/DevDiv/_git/VS-Platform/pullrequest/503146. Thanks!