Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New Line" options are not taking effect in VS 2022 Community (Version 17.12.0 Preview 1.0) #75393

Closed
vsfeedback opened this issue Oct 4, 2024 · 8 comments
Assignees
Milestone

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.


[regression] [worked-in:Version 17.11]
Despite having all of the "put X on a new line" options turned off, the auto complete and format document functionality is putting the brackets on new lines. I have had these turned off for years and they worked fine until this most recent VS 2022 community update.


Original Comments

Feedback Bot on 8/19/2024, 02:34 AM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Sam Harwell [MSFT] on 8/21/2024, 10:16 AM:

Hi Mitchell Russell,

Thank you for reporting this issue. Typically, when this occurs one of two things has occurred:

  1. The user has a .editorconfig file in the directory with the source file, or in one of its parent folders. Options defined in this file override options found in Tools → Options…, so you would need to review that file for consistency with the desired settings.
  2. The project sets the property <EnableCodeStyleInBuild>true</EnableCodeStyleInBuild>. When this property is enabled, the formatter ignores all options from Tools → Options… to ensure the behavior during builds is consistent with the IDE experience. When this property is enabled, customized options must be defined in .editorconfig or .globalconfig.

Documentation for these files can be found here:
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/configuration-files

If you have further questions, can you provide more information about which of these scenarios you are encountering?

Thank you,
Sam Harwell

Mitchell Russell on 9/15/2024, 03:22 PM:

(private comment, text removed)

Mitchell Russell on 9/22/2024, 09:03 AM:

Can we please get this elevated or some focus on it? Nothing I’ve tried has worked.

Feedback Bot on 8/28/2024, 00:51 AM:

We will close this report in 14 days because we don’t have enough information to investigate further. To keep the problem open, please provide the requested details.

Mitchell Russell on 9/10/2024, 07:37 PM:

Sam Harwell [MSFT] Sorry, I just saw this. I didn’t get an email when you replied last week.

This is happening in all of my projects, suddenly, when I upgraded to 17.12.0 Preview 1.0, with no other changes having occurred. I did not add an editorconfig or change anything else.

Is there anything else I can check? It’s occurring on two different computers after the upgrade.

Mitchell Russell on 9/22/2024, 08:55 AM:

(private comment, text removed)

Feedback Bot on 10/4/2024, 10:58 AM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 4, 2024
@caliberdigitalllc
Copy link

my very own VS 2022 Bug thread :) Such a proud father. (I'm Mitch).

@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 4, 2024
@arunchndr arunchndr added this to the 17.12 P3 milestone Oct 4, 2024
@tmat
Copy link
Member

tmat commented Oct 10, 2024

Fixed by #75417

@tmat tmat closed this as completed Oct 10, 2024
@caliberdigitalllc
Copy link

caliberdigitalllc commented Oct 26, 2024

Fixed by #75417

@sharwell @tmat - the latest version of VS that says it includes this fix, does not fix the problem. Can we re-open and keep working on this? I tried it across 3 different projects and the new line formatting options continue to be ignored.

@caliberdigitalllc
Copy link

@sharwell @tmat - tagging you again as this issue still remains in the very latest preview across multiple computers and multiple projects.

@RoLYroLLs
Copy link

RoLYroLLs commented Nov 13, 2024

This is happening with VS 17.12 GA. Just downloaded it and it's always adding a new line before an open bracket, no matter what setting I have in options. I even tried resetting all options to default, in case my settings were corrupt, and no matter what options I set, it continues to do the same.

EDIT: To be clear, this is happening in .razor files, not .cs files.

@caliberdigitalllc
Copy link

This is happening with VS 17.12 GA. Just downloaded it and it's always adding a new line before an open bracket, no matter what setting I have in options. I even tried resetting all options to default, in case my settings were corrupt, and no matter what options I set, it continues to do the same.

yeah I've been tagging @sharwell and @tmat but they aren't seeing the tags. I will start a new issue and try and get them to reopen this.

@caliberdigitalllc
Copy link

@RoLYroLLs - opened #75881 in hopes they come reopen this issue.

@GF-Huang

This comment has been minimized.

@dotnet dotnet locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants