Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref returns/locals: Quick Info omits "ref" modifier on properties & locals (needs test) #8453

Closed
dpoeschl opened this issue Feb 7, 2016 · 7 comments
Labels
Area-IDE Feature - Ref Locals and Returns Ref Locals and Returns Test Test failures in roslyn-CI
Milestone

Comments

@dpoeschl
Copy link
Contributor

dpoeschl commented Feb 7, 2016

Properties (no ref):
image

Locals (no ref):
image

Methods (ref shown):
image

@DustinCampbell
Copy link
Member

@jaredpar -- this falls into the "IDE basics" camp. Perhaps symbol display needs updating? Or, it might be that quick info needs to specify another symbol display flag (i.e. "modifiers")?

@dpoeschl dpoeschl added the Feature - Ref Locals and Returns Ref Locals and Returns label Feb 11, 2016
@VSadov VSadov modified the milestone: 2.0 (Preview 1) Jun 11, 2016
@gafter gafter modified the milestones: 2.0 (Preview 1), 2.0 (RC) Jun 20, 2016
@jaredpar jaredpar modified the milestones: 2.0 (RC), 2.0 (RTM) Jul 18, 2016
@jaredpar jaredpar modified the milestones: 2.1, 2.0 (RTM) Jan 12, 2017
@jaredpar jaredpar modified the milestones: 15.1, 15.3 Mar 9, 2017
@jaredpar jaredpar modified the milestones: 15.3, 15.later Apr 21, 2017
@jcouv
Copy link
Member

jcouv commented Dec 8, 2017

Looks like this was fixed already. Probably by @OmarTawfik, maybe as part of #22614

I'll go ahead and close. Thanks

image

image

image

@jcouv jcouv closed this as completed Dec 8, 2017
@jcouv jcouv added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Dec 8, 2017
@OmarTawfik
Copy link
Contributor

@jcouv in that case, I'd suggest we add tests for properties/locals before we close this issue. Not sure if they are covered. My PR was about structs only.

@jcouv
Copy link
Member

jcouv commented Dec 8, 2017

It turns out this was fixed before your PR for structs.
PR #14654 which I think fixed this did include compiler-level tests.
Thanks

@jcouv
Copy link
Member

jcouv commented Dec 8, 2017

Hum, Chuck's change only covered members that return ref (methods and properties), not locals. Not sure when that was fixed...

@OmarTawfik
Copy link
Contributor

We can just keep it opened and add a few tests for this. I think it can be quiet a small "up for grabs" item.

@jcouv jcouv reopened this Dec 10, 2017
@jcouv jcouv added Test Test failures in roslyn-CI and removed Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented labels Dec 15, 2017
@jcouv jcouv changed the title Ref returns/locals: Quick Info omits "ref" modifier on properties & locals Ref returns/locals: Quick Info omits "ref" modifier on properties & locals (needs test) Dec 15, 2017
@jcouv jcouv removed the Bug label Dec 30, 2017
@jaredpar jaredpar modified the milestones: 15.6, 16.0 Jan 4, 2018
@jinujoseph jinujoseph modified the milestones: 16.0, 16.1 Mar 6, 2019
@jinujoseph jinujoseph modified the milestones: 16.1, Backlog Apr 24, 2019
@CyrusNajmabadi
Copy link
Member

Looks good to me:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature - Ref Locals and Returns Ref Locals and Returns Test Test failures in roslyn-CI
Projects
None yet
Development

No branches or pull requests

10 participants