Skip to content

Commit 0f40573

Browse files
steveisokSteve Pfister
and
Steve Pfister
authored
Disable several GenericMath tests on iOS/tvOS (#61922)
The tests were failing on iOS/tvOS device runs. #61920 was created to track them. Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
1 parent 25ebdcf commit 0f40573

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/libraries/System.Runtime/tests/System/IntPtrTests.GenericMath.cs

+6
Original file line numberDiff line numberDiff line change
@@ -784,6 +784,7 @@ public static void CreateSaturatingFromCharTest()
784784
}
785785

786786
[Fact]
787+
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
787788
public static void CreateSaturatingFromInt16Test()
788789
{
789790
Assert.Equal((nint)0x00000000, NumberHelper<nint>.CreateSaturating<short>(0x0000));
@@ -846,6 +847,7 @@ public static void CreateSaturatingFromIntPtrTest()
846847
}
847848

848849
[Fact]
850+
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
849851
public static void CreateSaturatingFromSByteTest()
850852
{
851853
Assert.Equal((nint)0x00000000, NumberHelper<nint>.CreateSaturating<sbyte>(0x00));
@@ -949,6 +951,7 @@ public static void CreateTruncatingFromCharTest()
949951
}
950952

951953
[Fact]
954+
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
952955
public static void CreateTruncatingFromInt16Test()
953956
{
954957
if (Environment.Is64BitProcess)
@@ -1022,6 +1025,7 @@ public static void CreateTruncatingFromIntPtrTest()
10221025
}
10231026

10241027
[Fact]
1028+
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
10251029
public static void CreateTruncatingFromSByteTest()
10261030
{
10271031
if (Environment.Is64BitProcess)
@@ -1231,6 +1235,7 @@ public static void TryCreateFromCharTest()
12311235
}
12321236

12331237
[Fact]
1238+
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
12341239
public static void TryCreateFromInt16Test()
12351240
{
12361241
nint result;
@@ -1355,6 +1360,7 @@ public static void TryCreateFromIntPtrTest()
13551360
}
13561361

13571362
[Fact]
1363+
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
13581364
public static void TryCreateFromSByteTest()
13591365
{
13601366
nint result;

src/libraries/tests.proj

+1-1
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@
181181

182182
<ItemGroup Condition="'$(TargetOS)' == 'iOSSimulator' and '$(TargetArchitecture)' == 'arm64' and '$(RunDisablediOSTests)' != 'true'">
183183
<!-- Functional tests on arm64 simulator have problems with return codes from mlaunch -->
184-
<ProjectExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\$(TargetOS)\Simulator\**\*.Test.csproj" />
184+
<ProjectExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\iOS\Simulator\**\*.Test.csproj" />
185185
</ItemGroup>
186186

187187
<!-- Excluding all tests for devices until building on helix works properly -->

0 commit comments

Comments
 (0)