1) Remove [EventSourceAutoGenerate], we rely on just [EventSource] + no explicit ctors

2) Introduce a new global SourceGenerators - EventSourceGenerator (and move the existing impl from SPC.Generators to this new project)
3) Update slnx files (via the UpdateSolutionFiles task)
4) Migrate all classes with [EventSource] to use the SG. Except for the ones with EtwSelfDescribingEventFormat

Author: EgorBo

eng/generators.targets

@@ -40,6 +40,13 @@
                                      '$(DisableImplicitFrameworkReferences)' == 'true' and
                                      '@(ProjectReference->AnyHaveMetadataValue('Filename', 'System.Runtime.InteropServices'))' == 'true'
                                  )" />
+
+    <EnabledGenerators Include="EventSourceGenerator"
+                       Condition="'$(IsSourceProject)' == 'true' and
+                                 '$(MSBuildProjectExtension)' == '.csproj' and
+                                 (
+                                     '$(DisableImplicitFrameworkReferences)' == 'true'
+                                 )" />
   </ItemGroup>
 
   <ItemGroup Condition="'@(EnabledGenerators)' != '' and
@@ -70,6 +77,11 @@
                       OutputItemType="Analyzer"
                       SetConfiguration="Configuration=$(LibrariesConfiguration)"
                       Condition="@(EnabledGenerators->AnyHaveMetadataValue('Identity', 'ComInterfaceGenerator'))" />
+    <ProjectReference Include="$(LibrariesProjectRoot)System.Private.CoreLib\gen\EventSourceGenerator.csproj"
+                      ReferenceOutputAssembly="false"
+                      OutputItemType="Analyzer"
+                      SetConfiguration="Configuration=$(LibrariesConfiguration)"
+                      Condition="@(EnabledGenerators->AnyHaveMetadataValue('Identity', 'EventSourceGenerator'))" />
   </ItemGroup>
 
   <Target Name="ConfigureGenerators"

src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework/PerfEventSource.cs

@@ -10,10 +10,8 @@
 namespace ILCompiler.DependencyAnalysisFramework
 {
     [EventSource(Name = "Microsoft-ILCompiler-Graph-Perf")]
-    public class PerfEventSource : EventSource
+    public partial class PerfEventSource : EventSource
     {
-        private PerfEventSource() { }
-
         public static PerfEventSource Log = new PerfEventSource();
 
         public struct StartStopEvents : IDisposable

src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/PerfEventSource.cs

@@ -10,10 +10,8 @@
 namespace ILCompiler
 {
     [EventSource(Name = "Microsoft-ILCompiler-Perf")]
-    public class PerfEventSource : EventSource
+    public partial class PerfEventSource : EventSource
     {
-        private PerfEventSource() { }
-
         public static PerfEventSource Log = new PerfEventSource();
 
         public struct StartStopEvents : IDisposable

src/libraries/NetCoreAppLibrary.props

@@ -181,6 +181,7 @@
     <!-- List .NETCoreApp shared framework generator project names below. -->
     <NetCoreAppLibraryGenerator>
       ComInterfaceGenerator;
+      EventSourceGenerator;
       LibraryImportGenerator;
       JSImportGenerator;
       Microsoft.Interop.SourceGeneration;

src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/CDSCollectionETWBCLProvider.cs

@@ -19,15 +19,13 @@ namespace System.Collections.Concurrent
         Name = "System.Collections.Concurrent.ConcurrentCollectionsEventSource",
         Guid = "35167F8E-49B2-4b96-AB86-435B59336B5E"
         )]
-    internal sealed class CDSCollectionETWBCLProvider : EventSource
+    internal sealed partial class CDSCollectionETWBCLProvider : EventSource
     {
         /// <summary>
         /// Defines the singleton instance for the collection ETW provider.
         /// The collection provider GUID is {35167F8E-49B2-4b96-AB86-435B59336B5E}.
         /// </summary>
         public static readonly CDSCollectionETWBCLProvider Log = new CDSCollectionETWBCLProvider();
-        /// <summary>Prevent external instantiation.  All logging should go through the Log instance.</summary>
-        private CDSCollectionETWBCLProvider() { }
 
         /// <summary>Enabled for all keywords.</summary>
         private const EventKeywords ALL_KEYWORDS = (EventKeywords)(-1);

src/libraries/System.Data.Common/src/System/Data/Common/DataCommonEventSource.cs

@@ -7,7 +7,7 @@
 namespace System.Data
 {
     [EventSource(Name = "System.Data.DataCommonEventSource")]
-    internal sealed class DataCommonEventSource : EventSource
+    internal sealed partial class DataCommonEventSource : EventSource
     {
         internal static readonly DataCommonEventSource Log = new DataCommonEventSource();
         private static long s_nextScopeId;

src/libraries/System.Data.OleDb/src/System/Data/Common/DataCommonEventSource.cs

@@ -7,7 +7,7 @@
 namespace System.Data
 {
     [EventSource(Name = "System.Data.DataCommonEventSource")]
-    internal sealed class DataCommonEventSource : EventSource
+    internal sealed partial class DataCommonEventSource : EventSource
     {
         internal static readonly DataCommonEventSource Log = new DataCommonEventSource();
         private const int TraceEventId = 1;

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs

@@ -48,11 +48,9 @@ namespace System.Diagnostics.Metrics
     ///         not counting the special zero bucket. The default value is 160.
     ///       o reportDeltas - If true, the histogram will report deltas instead of whole accumulated values. The default value is false.
     /// </summary>
-    [EventSource(Name = MetricsEventSourceName)]
-    internal sealed class MetricsEventSource : EventSource
+    [EventSource(Name = "System.Diagnostics.Metrics")]
+    internal sealed partial class MetricsEventSource : EventSource
     {
-        private const string MetricsEventSourceName = "System.Diagnostics.Metrics";
-
         public static readonly MetricsEventSource Log = new();
 
         // Although this API isn't public, it is invoked via reflection from System.Private.CoreLib and needs the same back-compat
@@ -98,11 +96,6 @@ private CommandHandler Handler
             }
         }
 
-        private MetricsEventSource()
-            : base(MetricsEventSourceName, EventSourceSettings.EtwManifestEventFormat)
-        {
-        }
-
         /// <summary>
         /// Used to send ad-hoc diagnostics to humans.
         /// </summary>

src/libraries/System.Diagnostics.Tracing/ref/System.Diagnostics.Tracing.cs

@@ -155,6 +155,9 @@ protected EventSource(System.Diagnostics.Tracing.EventSourceSettings settings, p
         public EventSource(string eventSourceName) { }
         public EventSource(string eventSourceName, System.Diagnostics.Tracing.EventSourceSettings config) { }
         public EventSource(string eventSourceName, System.Diagnostics.Tracing.EventSourceSettings config, params string[]? traits) { }
+        public EventSource(string eventSourceName, Guid eventSourceGuid) { }
+        public EventSource(string eventSourceName, Guid eventSourceGuid, System.Diagnostics.Tracing.EventSourceSettings settings, params string[]? traits) { }
+
         public System.Exception? ConstructionException { get { throw null; } }
         public static System.Guid CurrentThreadActivityId { get { throw null; } }
         public System.Guid Guid { get { throw null; } }

src/libraries/System.Linq.Parallel/src/System/Linq/Parallel/Utils/PLINQETWProvider.cs

@@ -22,15 +22,13 @@ namespace System.Linq.Parallel
     [EventSource(
         Name = "System.Linq.Parallel.PlinqEventSource",
         Guid = "159eeeec-4a14-4418-a8fe-faabcd987887")]
-    internal sealed class PlinqEtwProvider : EventSource
+    internal sealed partial class PlinqEtwProvider : EventSource
     {
         /// <summary>
         /// Defines the singleton instance for the PLINQ ETW provider.
         /// The PLINQ Event provider GUID is {159eeeec-4a14-4418-a8fe-faabcd987887}.
         /// </summary>
         internal static readonly PlinqEtwProvider Log = new PlinqEtwProvider();
-        /// <summary>Prevent external instantiation.  All logging should go through the Log instance.</summary>
-        private PlinqEtwProvider() { }
 
         /// <summary>Cached id for the default scheduler.</summary>
         /// <remarks>If PLINQ ever supports other schedulers, that information will need to be passed into the query events.</remarks>