Skip to content

Commit 25dccd0

Browse files
authored
[wasm] don't fail the job if firefox debugger tests fail, as they are known to be unstable currently
1 parent 810a7f9 commit 25dccd0

File tree

4 files changed

+44
-1
lines changed

4 files changed

+44
-1
lines changed

eng/pipelines/common/platform-matrix.yml

+38
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ parameters:
2222
# Handled as an opt-in parameter to avoid excessive yaml.
2323
passPlatforms: false
2424
container: ''
25+
shouldContinueOnError: false
2526
jobParameters: {}
2627
variables: []
2728

@@ -38,6 +39,7 @@ jobs:
3839
archType: arm
3940
targetRid: linux-arm
4041
platform: Linux_arm
42+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
4143
container:
4244
image: ubuntu-18.04-cross-arm-20220426130400-6e40d49
4345
registry: mcr
@@ -63,6 +65,7 @@ jobs:
6365
archType: armv6
6466
targetRid: linux-armv6
6567
platform: Linux_armv6
68+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
6669
container:
6770
image: ubuntu-20.04-cross-armv6-raspbian-10-20211208135931-e6e3ac4
6871
registry: mcr
@@ -89,6 +92,7 @@ jobs:
8992
archType: arm64
9093
targetRid: linux-arm64
9194
platform: Linux_arm64
95+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
9296
container:
9397
${{ if eq(parameters.container, '') }}:
9498
image: ubuntu-18.04-cross-arm64-20220427171722-6e40d49
@@ -119,6 +123,7 @@ jobs:
119123
archType: x64
120124
targetRid: linux-musl-x64
121125
platform: Linux_musl_x64
126+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
122127
container:
123128
image: alpine-3.13-WithNode-20210910135845-c401c85
124129
registry: mcr
@@ -144,6 +149,7 @@ jobs:
144149
archType: arm
145150
targetRid: linux-musl-arm
146151
platform: Linux_musl_arm
152+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
147153
container:
148154
image: ubuntu-16.04-cross-arm-alpine-20210923140502-78f7860
149155
registry: mcr
@@ -171,6 +177,7 @@ jobs:
171177
archType: arm64
172178
targetRid: linux-musl-arm64
173179
platform: Linux_musl_arm64
180+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
174181
container:
175182
image: ubuntu-16.04-cross-arm64-alpine-20210923140502-78f7860
176183
registry: mcr
@@ -198,6 +205,7 @@ jobs:
198205
archType: arm64
199206
targetRid: linux-bionic-arm64
200207
platform: Linux_bionic_arm64
208+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
201209
container:
202210
image: ubuntu-18.04-android-20220131172314-3983b4e
203211
registry: mcr
@@ -226,6 +234,7 @@ jobs:
226234
archType: x64
227235
targetRid: linux-bionic-x64
228236
platform: Linux_bionic_x64
237+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
229238
container:
230239
image: ubuntu-18.04-android-20220131172314-3983b4e
231240
registry: mcr
@@ -250,6 +259,7 @@ jobs:
250259
archType: x64
251260
targetRid: linux-x64
252261
platform: Linux_x64
262+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
253263
container:
254264
${{ if eq(parameters.container, '') }}:
255265
image: centos-7-20210714125435-9b5bbc2
@@ -277,6 +287,7 @@ jobs:
277287
archType: x86
278288
targetRid: linux-x86
279289
platform: Linux_x86
290+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
280291
container:
281292
image: ubuntu-18.04-cross-x86-linux-20211022152824-f853169
282293
registry: mcr
@@ -304,6 +315,7 @@ jobs:
304315
archType: x64
305316
targetRid: linux-x64
306317
platform: Linux_x64
318+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
307319
container:
308320
image: centos-7-source-build-20210714125450-5d87b80
309321
registry: mcr
@@ -329,6 +341,7 @@ jobs:
329341
archType: s390x
330342
targetRid: linux-s390x
331343
platform: Linux_s390x
344+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
332345
container:
333346
image: ubuntu-18.04-cross-s390x-20201102145728-d6e0352
334347
registry: mcr
@@ -355,6 +368,7 @@ jobs:
355368
archType: wasm
356369
targetRid: browser-wasm
357370
platform: Browser_wasm
371+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
358372
container:
359373
image: ubuntu-18.04-webassembly-20220317214646-1ad56e8
360374
registry: mcr
@@ -379,6 +393,7 @@ jobs:
379393
archType: wasm
380394
targetRid: browser-wasm
381395
platform: Browser_wasm_firefox
396+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
382397
container:
383398
image: ubuntu-18.04-webassembly-20220317214646-1ad56e8
384399
registry: mcr
@@ -403,6 +418,7 @@ jobs:
403418
archType: wasm
404419
targetRid: browser-wasm
405420
platform: Browser_wasm_win
421+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
406422
jobParameters:
407423
hostedOs: windows
408424
runtimeFlavor: ${{ parameters.runtimeFlavor }}
@@ -423,6 +439,7 @@ jobs:
423439
archType: x64
424440
targetRid: freebsd-x64
425441
platform: FreeBSD_x64
442+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
426443
container:
427444
image: ubuntu-18.04-cross-freebsd-12-20210917001307-f13d79e
428445
registry: mcr
@@ -448,6 +465,7 @@ jobs:
448465
archType: x64
449466
targetRid: android-x64
450467
platform: Android_x64
468+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
451469
container:
452470
image: ubuntu-18.04-android-20220131172314-3983b4e
453471
registry: mcr
@@ -472,6 +490,7 @@ jobs:
472490
archType: x86
473491
targetRid: android-x86
474492
platform: Android_x86
493+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
475494
container:
476495
image: ubuntu-18.04-android-20220131172314-3983b4e
477496
registry: mcr
@@ -496,6 +515,7 @@ jobs:
496515
archType: arm
497516
targetRid: android-arm
498517
platform: Android_arm
518+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
499519
container:
500520
image: ubuntu-18.04-android-20220131172314-3983b4e
501521
registry: mcr
@@ -520,6 +540,7 @@ jobs:
520540
archType: arm64
521541
targetRid: android-arm64
522542
platform: Android_arm64
543+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
523544
container:
524545
image: ubuntu-18.04-android-20220131172314-3983b4e
525546
registry: mcr
@@ -544,6 +565,7 @@ jobs:
544565
archType: x64
545566
targetRid: maccatalyst-x64
546567
platform: MacCatalyst_x64
568+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
547569
jobParameters:
548570
runtimeFlavor: mono
549571
stagedBuild: ${{ parameters.stagedBuild }}
@@ -565,6 +587,7 @@ jobs:
565587
archType: arm64
566588
targetRid: maccatalyst-arm64
567589
platform: MacCatalyst_arm64
590+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
568591
jobParameters:
569592
runtimeFlavor: mono
570593
stagedBuild: ${{ parameters.stagedBuild }}
@@ -586,6 +609,7 @@ jobs:
586609
archType: arm64
587610
targetRid: tvos-arm64
588611
platform: tvOS_arm64
612+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
589613
jobParameters:
590614
runtimeFlavor: mono
591615
stagedBuild: ${{ parameters.stagedBuild }}
@@ -607,6 +631,7 @@ jobs:
607631
archType: x64
608632
targetRid: tvossimulator-x64
609633
platform: tvOSSimulator_x64
634+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
610635
jobParameters:
611636
runtimeFlavor: mono
612637
stagedBuild: ${{ parameters.stagedBuild }}
@@ -628,6 +653,7 @@ jobs:
628653
archType: arm64
629654
targetRid: tvossimulator-arm64
630655
platform: tvOSSimulator_arm64
656+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
631657
jobParameters:
632658
runtimeFlavor: mono
633659
stagedBuild: ${{ parameters.stagedBuild }}
@@ -649,6 +675,7 @@ jobs:
649675
archType: arm
650676
targetRid: ios-arm
651677
platform: iOS_arm
678+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
652679
jobParameters:
653680
runtimeFlavor: mono
654681
stagedBuild: ${{ parameters.stagedBuild }}
@@ -670,6 +697,7 @@ jobs:
670697
archType: arm64
671698
targetRid: ios-arm64
672699
platform: iOS_arm64
700+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
673701
jobParameters:
674702
runtimeFlavor: mono
675703
stagedBuild: ${{ parameters.stagedBuild }}
@@ -691,6 +719,7 @@ jobs:
691719
archType: x64
692720
targetRid: iossimulator-x64
693721
platform: iOSSimulator_x64
722+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
694723
jobParameters:
695724
runtimeFlavor: mono
696725
stagedBuild: ${{ parameters.stagedBuild }}
@@ -712,6 +741,7 @@ jobs:
712741
archType: x86
713742
targetRid: iossimulator-x86
714743
platform: iOSsimulator_x86
744+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
715745
jobParameters:
716746
runtimeFlavor: mono
717747
stagedBuild: ${{ parameters.stagedBuild }}
@@ -734,6 +764,7 @@ jobs:
734764
archType: arm64
735765
targetRid: iossimulator-arm64
736766
platform: iOSSimulator_arm64
767+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
737768
jobParameters:
738769
runtimeFlavor: mono
739770
stagedBuild: ${{ parameters.stagedBuild }}
@@ -755,6 +786,7 @@ jobs:
755786
archType: arm64
756787
targetRid: osx-arm64
757788
platform: OSX_arm64
789+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
758790
jobParameters:
759791
runtimeFlavor: ${{ parameters.runtimeFlavor }}
760792
stagedBuild: ${{ parameters.stagedBuild }}
@@ -777,6 +809,7 @@ jobs:
777809
archType: x64
778810
targetRid: osx-x64
779811
platform: OSX_x64
812+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
780813
jobParameters:
781814
runtimeFlavor: ${{ parameters.runtimeFlavor }}
782815
stagedBuild: ${{ parameters.stagedBuild }}
@@ -798,6 +831,7 @@ jobs:
798831
archType: armel
799832
targetRid: tizen-armel
800833
platform: Tizen_armel
834+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
801835
container:
802836
image: ubuntu-18.04-cross-armel-tizen-20210719212651-8b02f56
803837
registry: mcr
@@ -825,6 +859,7 @@ jobs:
825859
archType: x64
826860
targetRid: win-x64
827861
platform: windows_x64
862+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
828863
jobParameters:
829864
runtimeFlavor: ${{ parameters.runtimeFlavor }}
830865
stagedBuild: ${{ parameters.stagedBuild }}
@@ -846,6 +881,7 @@ jobs:
846881
archType: x86
847882
targetRid: win-x86
848883
platform: windows_x86
884+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
849885
jobParameters:
850886
runtimeFlavor: ${{ parameters.runtimeFlavor }}
851887
stagedBuild: ${{ parameters.stagedBuild }}
@@ -866,6 +902,7 @@ jobs:
866902
archType: arm
867903
targetRid: win-arm
868904
platform: windows_arm
905+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
869906
jobParameters:
870907
runtimeFlavor: ${{ parameters.runtimeFlavor }}
871908
stagedBuild: ${{ parameters.stagedBuild }}
@@ -887,6 +924,7 @@ jobs:
887924
archType: arm64
888925
targetRid: win-arm64
889926
platform: windows_arm64
927+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
890928
jobParameters:
891929
runtimeFlavor: ${{ parameters.runtimeFlavor }}
892930
stagedBuild: ${{ parameters.stagedBuild }}

eng/pipelines/common/templates/wasm-debugger-tests.yml

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ parameters:
22
alwaysRun: false
33
isExtraPlatformsBuild: false
44
browser: 'chrome'
5+
shouldContinueOnError: false
56
platforms: []
67

78
jobs:
@@ -14,6 +15,7 @@ jobs:
1415
buildConfig: Release
1516
runtimeFlavor: mono
1617
platforms: ${{ parameters.platforms }}
18+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
1719
variables:
1820
# map dependencies variables to local variables
1921
- name: wasmdebuggertestsContainsChange

eng/pipelines/common/xplat-setup.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@ parameters:
99
platform: ''
1010
targetRid: ''
1111
jobParameters: {}
12+
shouldContinueOnError: false
1213
variables: []
1314

1415
jobs:
1516
- template: ${{ coalesce(parameters.helixQueuesTemplate, parameters.jobTemplate) }}
1617
parameters:
17-
shouldContinueOnError: ${{ and(endsWith(variables['Build.DefinitionName'], 'staging'), eq(variables['Build.Reason'], 'PullRequest')) }}
18+
shouldContinueOnError: ${{ or(parameters.shouldContinueOnError, and(endsWith(variables['Build.DefinitionName'], 'staging'), eq(variables['Build.Reason'], 'PullRequest'))) }}
1819

1920
# keep in sync with /eng/pipelines/common/variables.yml
2021
dependOnEvaluatePaths: ${{ and(eq(variables['Build.Reason'], 'PullRequest'), in(variables['Build.DefinitionName'], 'runtime', 'runtime-staging', 'runtime-community', 'runtime-extra-platforms')) }}

eng/pipelines/runtime-extra-platforms-wasm.yml

+2
Original file line numberDiff line numberDiff line change
@@ -124,3 +124,5 @@ jobs:
124124
- Browser_wasm_firefox
125125
browser: firefox
126126
alwaysRun: ${{ parameters.isWasmOnlyBuild }}
127+
# ff tests are unstable currently
128+
shouldContinueOnError: true

0 commit comments

Comments
 (0)