ILLink: Fill in FeatureCheckDataflow.cs assertions with issue links (#102679)

jtschuster · web-flow · commit 40ff2ecd8607 · 2024-06-04T12:21:37.000-07:00
Adds issues links / explanations to FeatureCheckDataflow
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/DynamicObjects.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/DynamicObjects.cs
@@ -154,7 +154,7 @@ static void MethodWithRequires ()
 			}
 
 			[ExpectedWarning ("IL2026", nameof (MethodWithRequires))]
-			[ExpectedWarning ("IL3050", nameof (MethodWithRequires), Tool.Analyzer | Tool.NativeAot, "")]
+			[ExpectedWarning ("IL3050", nameof (MethodWithRequires), Tool.Analyzer | Tool.NativeAot, "NativeAOT Specific Warning")]
 			public static void Test ()
 			{
 				MethodWithRequires ();
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/ExponentialDataFlow.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/ExponentialDataFlow.cs
@@ -94,7 +94,7 @@ class GenericTypeWithRequires<
 			{
 			}
 
-			[ExpectedWarning ("IL3050", Tool.Analyzer | Tool.NativeAot, "")]
+			[ExpectedWarning ("IL3050", Tool.Analyzer | Tool.NativeAot, "NativeAOT Specific Warning")]
 			// The way we track arrays causes the analyzer to track exponentially many
 			// ArrayValues in the ValueSet for the pattern in this method, hitting the limit.
 			// When this happens, we replace the ValueSet with an unknown value, producing
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/FeatureCheckDataFlow.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/FeatureCheckDataFlow.cs

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ static void MethodWithRequires ()`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`[ExpectedWarning ("IL2026", nameof (MethodWithRequires))]`
`157`		`- [ExpectedWarning ("IL3050", nameof (MethodWithRequires), Tool.Analyzer \| Tool.NativeAot, "")]`
	`157`	`+ [ExpectedWarning ("IL3050", nameof (MethodWithRequires), Tool.Analyzer \| Tool.NativeAot, "NativeAOT Specific Warning")]`
`158`	`158`	`public static void Test ()`
`159`	`159`	`{`
`160`	`160`	`MethodWithRequires ();`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ class GenericTypeWithRequires<`
`94`	`94`	`{`
`95`	`95`	`}`
`96`	`96`
`97`		`- [ExpectedWarning ("IL3050", Tool.Analyzer \| Tool.NativeAot, "")]`
	`97`	`+ [ExpectedWarning ("IL3050", Tool.Analyzer \| Tool.NativeAot, "NativeAOT Specific Warning")]`
`98`	`98`	`// The way we track arrays causes the analyzer to track exponentially many`
`99`	`99`	`// ArrayValues in the ValueSet for the pattern in this method, hitting the limit.`
`100`	`100`	`// When this happens, we replace the ValueSet with an unknown value, producing`