Skip to content

Commit 438dabb

Browse files
authored
Disable terminal logger when running from root build script (#99036)
* Disable terminal logger when running from root build script Since the 9.0-preview1 bump the msbuild terminal logger was used again since the option from Directory.Build.rsp was ignored. The reason is that we're using Build.proj from an arcade nuget package so the file isn't in the directory tree above, it looks like it was only working due to an msbuild bug before. Add the -tl:false option into the build scripts directly. Individual invocations of `dotnet build` for repo projects still work because there the Directory.Build.rsp is in the directory tree above. * Use /tl instead of -tl on Windows
1 parent 0a210e8 commit 438dabb

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

eng/build.ps1

+3
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,9 @@ if ($env:TreatWarningsAsErrors -eq 'false') {
325325
$arguments += " -warnAsError 0"
326326
}
327327

328+
# disable terminal logger for now: https://github.com/dotnet/runtime/issues/97211
329+
$arguments += " /tl:false"
330+
328331
# Disable targeting pack caching as we reference a partially constructed targeting pack and update it later.
329332
# The later changes are ignored when using the cache.
330333
$env:DOTNETSDK_ALLOW_TARGETING_PACK_CACHING=0

eng/build.sh

+3
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,9 @@ if [[ "${TreatWarningsAsErrors:-}" == "false" ]]; then
553553
arguments="$arguments -warnAsError 0"
554554
fi
555555

556+
# disable terminal logger for now: https://github.com/dotnet/runtime/issues/97211
557+
arguments="$arguments -tl:false"
558+
556559
initDistroRid "$os" "$arch" "$crossBuild"
557560

558561
# Disable targeting pack caching as we reference a partially constructed targeting pack and update it later.

0 commit comments

Comments
 (0)