Skip to content

Commit 453fb98

Browse files
authored
Fix NumberFormatInfoGroupSize test (#120546)
* Fix NumberFormatInfoGroupSize test * Fix coding style
1 parent 9f8141b commit 453fb98

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/libraries/System.Runtime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,24 @@ public class NumberFormatInfoNumberGroupSizes
1010
{
1111
public static IEnumerable<object[]> NumberGroupSizes_TestData()
1212
{
13-
yield return new object[] { NumberFormatInfo.InvariantInfo, new int[] { 3 } };
14-
yield return new object[] { CultureInfo.GetCultureInfo("en-US").NumberFormat, new int[] { 3 } };
13+
yield return new object[] { "Invariant", NumberFormatInfo.InvariantInfo, new int[] { 3 }, null };
14+
yield return new object[] { "en-US", CultureInfo.GetCultureInfo("en-US").NumberFormat, new int[] { 3 }, null };
1515

1616
// Culture does not exist on Windows 7 and in Browser's ICU
1717
if (!PlatformDetection.IsWindows7 && PlatformDetection.IsNotBrowser)
1818
{
19-
yield return new object[] { CultureInfo.GetCultureInfo("ur-IN").NumberFormat, NumberFormatInfoData.UrINNumberGroupSizes() };
19+
yield return new object[] { "ur-IN", CultureInfo.GetCultureInfo("ur-IN").NumberFormat, NumberFormatInfoData.UrINNumberGroupSizes(), new int[] { 3, 2 } };
2020
}
2121
}
2222

2323
[Theory]
2424
[MemberData(nameof(NumberGroupSizes_TestData))]
25-
public void NumberGroupSizes_Get_ReturnsExpected(NumberFormatInfo format, int[] expected)
25+
public void NumberGroupSizes_Get_ReturnsExpected(string cultureName, NumberFormatInfo format, int[] expected1, int[] expected2)
2626
{
27-
Assert.Equal(expected, format.NumberGroupSizes);
27+
int[] actual = format.NumberGroupSizes;
28+
Assert.True(expected1.SequenceEqual(actual) || (expected2 is not null && expected2.SequenceEqual(actual)),
29+
$"Expected: [{string.Join(", ", expected1)}] or [{(expected2 is null ? "<null>" : string.Join(", ", expected2))}], Actual: [{string.Join(", ", actual)}]"
30+
+ $"{Environment.NewLine}Culture: {cultureName}");
2831
}
2932

3033
[Theory]

0 commit comments

Comments
 (0)