Skip to content

Commit 4771080

Browse files
committed
Update Matrix4x4Tests.cs
1 parent c8caa3b commit 4771080

File tree

1 file changed

+23
-22
lines changed

1 file changed

+23
-22
lines changed

src/libraries/System.Numerics.Vectors/tests/Matrix4x4Tests.cs

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -820,9 +820,7 @@ public void Matrix4x4CreateReflectionTest01()
820820
float d = Vector3.Dot(v, plane.Normal);
821821
Vector3 vp = point - 2.0f * d * plane.Normal;
822822

823-
AssertExtensions.Equal(vp.X, rp.X, 0.0f);
824-
AssertExtensions.Equal(vp.Y, rp.Y, 0.0f);
825-
AssertExtensions.Equal(vp.Z, rp.Z, 0.0f);
823+
Assert.True(MathHelper.Equal(rp, vp), "Matrix4x4.CreateReflection did not provide expected value.");
826824
}
827825
}
828826
}
@@ -833,25 +831,28 @@ public void Matrix4x4CreateReflectionTest02()
833831
Plane plane = new Plane(0, 1, 0, 60);
834832
Matrix4x4 actual = Matrix4x4.CreateReflection(plane);
835833

836-
AssertExtensions.Equal(1.0f, actual.M11, 0.0f);
837-
AssertExtensions.Equal(0.0f, actual.M12, 0.0f);
838-
AssertExtensions.Equal(0.0f, actual.M13, 0.0f);
839-
AssertExtensions.Equal(0.0f, actual.M14, 0.0f);
840-
841-
AssertExtensions.Equal(0.0f, actual.M21, 0.0f);
842-
AssertExtensions.Equal(-1.0f, actual.M22, 0.0f);
843-
AssertExtensions.Equal(0.0f, actual.M23, 0.0f);
844-
AssertExtensions.Equal(0.0f, actual.M24, 0.0f);
845-
846-
AssertExtensions.Equal(0.0f, actual.M31, 0.0f);
847-
AssertExtensions.Equal(0.0f, actual.M32, 0.0f);
848-
AssertExtensions.Equal(1.0f, actual.M33, 0.0f);
849-
AssertExtensions.Equal(0.0f, actual.M34, 0.0f);
850-
851-
AssertExtensions.Equal(-0.0f, actual.M41, 0.0f);
852-
AssertExtensions.Equal(-120.0f, actual.M42, 0.0f);
853-
AssertExtensions.Equal(-0.0f, actual.M43, 0.0f);
854-
AssertExtensions.Equal(1.0f, actual.M44, 0.0f);
834+
Matrix4x4 expected = new Matrix4x4();
835+
expected.M11 = 1.0f;
836+
expected.M12 = 0.0f;
837+
expected.M13 = 0.0f;
838+
expected.M14 = 0.0f;
839+
840+
expected.M21 = 0.0f;
841+
expected.M22 = -1.0f;
842+
expected.M23 = 0.0f;
843+
expected.M24 = 0.0f;
844+
845+
expected.M31 = 0.0f;
846+
expected.M32 = 0.0f;
847+
expected.M33 = 1.0f;
848+
expected.M34 = 0.0f;
849+
850+
expected.M41 = 0.0f;
851+
expected.M42 = -120.0f;
852+
expected.M43 = 0.0f;
853+
expected.M44 = 1.0f;
854+
855+
Assert.True(MathHelper.Equal(expected, actual), "Matrix4x4.CreateReflection did not return the expected value.");
855856
}
856857

857858
// A test for CreateRotationZ (float)

0 commit comments

Comments
 (0)