Skip to content

Commit 4e5463d

Browse files
authored
Fix nullable annotations on HttpClient.Post/Put/PatchAsync (#44880)
Null content is allowed.
1 parent a60137c commit 4e5463d

File tree

2 files changed

+24
-24
lines changed

2 files changed

+24
-24
lines changed

src/libraries/System.Net.Http/ref/System.Net.Http.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -78,18 +78,18 @@ protected override void Dispose(bool disposing) { }
7878
public System.Threading.Tasks.Task<string> GetStringAsync(string? requestUri, System.Threading.CancellationToken cancellationToken) { throw null; }
7979
public System.Threading.Tasks.Task<string> GetStringAsync(System.Uri? requestUri) { throw null; }
8080
public System.Threading.Tasks.Task<string> GetStringAsync(System.Uri? requestUri, System.Threading.CancellationToken cancellationToken) { throw null; }
81-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PatchAsync(string? requestUri, System.Net.Http.HttpContent content) { throw null; }
82-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PatchAsync(string? requestUri, System.Net.Http.HttpContent content, System.Threading.CancellationToken cancellationToken) { throw null; }
83-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PatchAsync(System.Uri? requestUri, System.Net.Http.HttpContent content) { throw null; }
84-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PatchAsync(System.Uri? requestUri, System.Net.Http.HttpContent content, System.Threading.CancellationToken cancellationToken) { throw null; }
85-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PostAsync(string? requestUri, System.Net.Http.HttpContent content) { throw null; }
86-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PostAsync(string? requestUri, System.Net.Http.HttpContent content, System.Threading.CancellationToken cancellationToken) { throw null; }
87-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PostAsync(System.Uri? requestUri, System.Net.Http.HttpContent content) { throw null; }
88-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PostAsync(System.Uri? requestUri, System.Net.Http.HttpContent content, System.Threading.CancellationToken cancellationToken) { throw null; }
89-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PutAsync(string? requestUri, System.Net.Http.HttpContent content) { throw null; }
90-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PutAsync(string? requestUri, System.Net.Http.HttpContent content, System.Threading.CancellationToken cancellationToken) { throw null; }
91-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PutAsync(System.Uri? requestUri, System.Net.Http.HttpContent content) { throw null; }
92-
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PutAsync(System.Uri? requestUri, System.Net.Http.HttpContent content, System.Threading.CancellationToken cancellationToken) { throw null; }
81+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PatchAsync(string? requestUri, System.Net.Http.HttpContent? content) { throw null; }
82+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PatchAsync(string? requestUri, System.Net.Http.HttpContent? content, System.Threading.CancellationToken cancellationToken) { throw null; }
83+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PatchAsync(System.Uri? requestUri, System.Net.Http.HttpContent? content) { throw null; }
84+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PatchAsync(System.Uri? requestUri, System.Net.Http.HttpContent? content, System.Threading.CancellationToken cancellationToken) { throw null; }
85+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PostAsync(string? requestUri, System.Net.Http.HttpContent? content) { throw null; }
86+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PostAsync(string? requestUri, System.Net.Http.HttpContent? content, System.Threading.CancellationToken cancellationToken) { throw null; }
87+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PostAsync(System.Uri? requestUri, System.Net.Http.HttpContent? content) { throw null; }
88+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PostAsync(System.Uri? requestUri, System.Net.Http.HttpContent? content, System.Threading.CancellationToken cancellationToken) { throw null; }
89+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PutAsync(string? requestUri, System.Net.Http.HttpContent? content) { throw null; }
90+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PutAsync(string? requestUri, System.Net.Http.HttpContent? content, System.Threading.CancellationToken cancellationToken) { throw null; }
91+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PutAsync(System.Uri? requestUri, System.Net.Http.HttpContent? content) { throw null; }
92+
public System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> PutAsync(System.Uri? requestUri, System.Net.Http.HttpContent? content, System.Threading.CancellationToken cancellationToken) { throw null; }
9393
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
9494
public System.Net.Http.HttpResponseMessage Send(System.Net.Http.HttpRequestMessage request) { throw null; }
9595
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]

src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -376,48 +376,48 @@ public Task<HttpResponseMessage> GetAsync(string? requestUri, HttpCompletionOpti
376376
public Task<HttpResponseMessage> GetAsync(Uri? requestUri, HttpCompletionOption completionOption, CancellationToken cancellationToken) =>
377377
SendAsync(CreateRequestMessage(HttpMethod.Get, requestUri), completionOption, cancellationToken);
378378

379-
public Task<HttpResponseMessage> PostAsync(string? requestUri, HttpContent content) =>
379+
public Task<HttpResponseMessage> PostAsync(string? requestUri, HttpContent? content) =>
380380
PostAsync(CreateUri(requestUri), content);
381381

382-
public Task<HttpResponseMessage> PostAsync(Uri? requestUri, HttpContent content) =>
382+
public Task<HttpResponseMessage> PostAsync(Uri? requestUri, HttpContent? content) =>
383383
PostAsync(requestUri, content, CancellationToken.None);
384384

385-
public Task<HttpResponseMessage> PostAsync(string? requestUri, HttpContent content, CancellationToken cancellationToken) =>
385+
public Task<HttpResponseMessage> PostAsync(string? requestUri, HttpContent? content, CancellationToken cancellationToken) =>
386386
PostAsync(CreateUri(requestUri), content, cancellationToken);
387387

388-
public Task<HttpResponseMessage> PostAsync(Uri? requestUri, HttpContent content, CancellationToken cancellationToken)
388+
public Task<HttpResponseMessage> PostAsync(Uri? requestUri, HttpContent? content, CancellationToken cancellationToken)
389389
{
390390
HttpRequestMessage request = CreateRequestMessage(HttpMethod.Post, requestUri);
391391
request.Content = content;
392392
return SendAsync(request, cancellationToken);
393393
}
394394

395-
public Task<HttpResponseMessage> PutAsync(string? requestUri, HttpContent content) =>
395+
public Task<HttpResponseMessage> PutAsync(string? requestUri, HttpContent? content) =>
396396
PutAsync(CreateUri(requestUri), content);
397397

398-
public Task<HttpResponseMessage> PutAsync(Uri? requestUri, HttpContent content) =>
398+
public Task<HttpResponseMessage> PutAsync(Uri? requestUri, HttpContent? content) =>
399399
PutAsync(requestUri, content, CancellationToken.None);
400400

401-
public Task<HttpResponseMessage> PutAsync(string? requestUri, HttpContent content, CancellationToken cancellationToken) =>
401+
public Task<HttpResponseMessage> PutAsync(string? requestUri, HttpContent? content, CancellationToken cancellationToken) =>
402402
PutAsync(CreateUri(requestUri), content, cancellationToken);
403403

404-
public Task<HttpResponseMessage> PutAsync(Uri? requestUri, HttpContent content, CancellationToken cancellationToken)
404+
public Task<HttpResponseMessage> PutAsync(Uri? requestUri, HttpContent? content, CancellationToken cancellationToken)
405405
{
406406
HttpRequestMessage request = CreateRequestMessage(HttpMethod.Put, requestUri);
407407
request.Content = content;
408408
return SendAsync(request, cancellationToken);
409409
}
410410

411-
public Task<HttpResponseMessage> PatchAsync(string? requestUri, HttpContent content) =>
411+
public Task<HttpResponseMessage> PatchAsync(string? requestUri, HttpContent? content) =>
412412
PatchAsync(CreateUri(requestUri), content);
413413

414-
public Task<HttpResponseMessage> PatchAsync(Uri? requestUri, HttpContent content) =>
414+
public Task<HttpResponseMessage> PatchAsync(Uri? requestUri, HttpContent? content) =>
415415
PatchAsync(requestUri, content, CancellationToken.None);
416416

417-
public Task<HttpResponseMessage> PatchAsync(string? requestUri, HttpContent content, CancellationToken cancellationToken) =>
417+
public Task<HttpResponseMessage> PatchAsync(string? requestUri, HttpContent? content, CancellationToken cancellationToken) =>
418418
PatchAsync(CreateUri(requestUri), content, cancellationToken);
419419

420-
public Task<HttpResponseMessage> PatchAsync(Uri? requestUri, HttpContent content, CancellationToken cancellationToken)
420+
public Task<HttpResponseMessage> PatchAsync(Uri? requestUri, HttpContent? content, CancellationToken cancellationToken)
421421
{
422422
HttpRequestMessage request = CreateRequestMessage(HttpMethod.Patch, requestUri);
423423
request.Content = content;

0 commit comments

Comments
 (0)