Skip to content

Commit 50fcbe5

Browse files
noahfalkjkotas
andauthored
Apply suggestions from code review
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
1 parent a624e38 commit 50fcbe5

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/coreclr/vm/method.inl

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ inline bool MethodDesc::IsILStub()
137137
// code viewing, stepping, etc). Partly this is a user experience consideration to preserve the
138138
// abstraction users would expect based on source code and assembly contents. Partly it is also a technical
139139
// limitation that many parts of diagnostics don't know how to work with methods that aren't backed by
140-
// metadata and IL in a module. Currently this method only triages methods whose code was generated from IL.
140+
// metadata and IL in a module.
141141
inline bool MethodDesc::IsDiagnosticsHidden()
142142
{
143143
// Although good user experience can be subjective these are guidelines:
@@ -151,10 +151,8 @@ inline bool MethodDesc::IsDiagnosticsHidden()
151151
// one frame for these calls as well but we haven't always done this consistently. For calls that redirect to another managed method users
152152
// tolerate if the runtime-implemented frame is missing because they can still see the managed target method.
153153

154-
// NOTE: Currently this method doesn't filter out unboxing stubs although it seems like it should. I haven't identified a concrete
155-
// scenario that produces a bad user experience but more exploration might find one.
156154
WRAPPER_NO_CONTRACT;
157-
return IsILStub() || IsAsyncThunkMethod();
155+
return IsILStub() || IsAsyncThunkMethod() || IsWrapperStub();
158156
}
159157

160158
inline BOOL MethodDesc::IsQCall()

0 commit comments

Comments
 (0)