Skip to content

Commit 53330eb

Browse files
github-actions[bot]wfurtManickaP
authored
[release/9.0-staging] disable multicast tests on AzureLinux (#119475)
Backport of #117694 to release/9.0-staging /cc @jeffhandley @wfurt @ManickaP ## Customer Impact Related to #115502. Default AZL has firewall that blocks multicast. - [ ] Customer reported - [x] Found internally ## Regression - [ ] Yes - [x] No ## Testing This was verified in main and is also being backported to release/8.0-staging via #115502, to ensure the test doesn't fail in our baseline extra-platforms tests. ## Risk Low. Conditional test disablement. --------- Co-authored-by: wfurt <tweinfurt@yahoo.com> Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
1 parent bfc7448 commit 53330eb

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ namespace System.Net.Sockets.Tests
1515
public partial class SocketOptionNameTest
1616
{
1717
private static bool SocketsReuseUnicastPortSupport => Capability.SocketsReuseUnicastPortSupport().HasValue;
18+
// Does not work on Nano and Qemu and AzureLinux has firewall enabled by default
19+
private static readonly bool CanRunMulticastTests = !(PlatformDetection.IsWindowsNanoServer || PlatformDetection.IsWindowsServerCore ||
20+
PlatformDetection.IsAzureLinux || PlatformDetection.IsQemuLinux);
1821

1922
[ConditionalFact(nameof(SocketsReuseUnicastPortSupport))]
2023
public void ReuseUnicastPort_CreateSocketGetOption()
@@ -65,8 +68,7 @@ public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetS
6568
}
6669
}
6770

68-
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))] // Skip on Nano: https://github.com/dotnet/runtime/issues/26286
69-
[ActiveIssue("https://github.com/dotnet/runtime/issues/104547", typeof(PlatformDetection), nameof(PlatformDetection.IsQemuLinux))]
71+
[ConditionalFact(nameof(CanRunMulticastTests))]
7072
[ActiveIssue("https://github.com/dotnet/runtime/issues/113827", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile))]
7173
[SkipOnPlatform(TestPlatforms.OSX, "Multicast interface selection fails on macOS 14+ due to changes in how the system handles network interface parameters")]
7274
public async Task MulticastInterface_Set_AnyInterface_Succeeds()
@@ -124,10 +126,9 @@ public void MulticastInterface_Set_InvalidIndex_Throws()
124126
}
125127
}
126128

127-
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))] // Skip on Nano: https://github.com/dotnet/runtime/issues/26286
129+
[ConditionalFact(nameof(CanRunMulticastTests))]
128130
[SkipOnPlatform(TestPlatforms.OSX | TestPlatforms.FreeBSD, "Expected behavior is different on OSX or FreeBSD")]
129131
[ActiveIssue("https://github.com/dotnet/runtime/issues/52124", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
130-
[ActiveIssue("https://github.com/dotnet/runtime/issues/104547", typeof(PlatformDetection), nameof(PlatformDetection.IsQemuLinux))]
131132
public async Task MulticastInterface_Set_IPv6_AnyInterface_Succeeds()
132133
{
133134
// On all platforms, index 0 means "any interface"

0 commit comments

Comments
 (0)