Fix impSIMDMinMax (#1774)

CarolEidt · web-flow · commit 5c9338e09ad0 · 2020-01-15T17:30:43.000-08:00
When taking the no-AVX, no-SSE42 path, ensure that it calls `lvaSetStruct` before `gtNewLclvNode`. Fix #1667
diff --git a/src/coreclr/src/jit/simd.cpp b/src/coreclr/src/jit/simd.cpp
@@ -1924,8 +1924,8 @@ GenTree* Compiler::impSIMDMinMax(SIMDIntrinsicID      intrinsicId,
         if ((op1->gtFlags & GTF_SIDE_EFFECT) != 0)
         {
             op1LclNum = lvaGrabTemp(true DEBUGARG("SIMD Min/Max"));
-            dupOp1    = gtNewLclvNode(op1LclNum, op1->TypeGet());
             lvaSetStruct(op1LclNum, typeHnd, false);
+            dupOp1    = gtNewLclvNode(op1LclNum, op1->TypeGet());
             op1Assign = gtNewTempAssign(op1LclNum, op1);
             op1       = gtNewLclvNode(op1LclNum, op1->TypeGet());
         }
@@ -1937,8 +1937,8 @@ GenTree* Compiler::impSIMDMinMax(SIMDIntrinsicID      intrinsicId,
         if ((op2->gtFlags & GTF_SIDE_EFFECT) != 0)
         {
             op2LclNum = lvaGrabTemp(true DEBUGARG("SIMD Min/Max"));
-            dupOp2    = gtNewLclvNode(op2LclNum, op2->TypeGet());
             lvaSetStruct(op2LclNum, typeHnd, false);
+            dupOp2    = gtNewLclvNode(op2LclNum, op2->TypeGet());
             op2Assign = gtNewTempAssign(op2LclNum, op2);
             op2       = gtNewLclvNode(op2LclNum, op2->TypeGet());
         }

Original file line number	Diff line number	Diff line change
`@@ -1924,8 +1924,8 @@ GenTree* Compiler::impSIMDMinMax(SIMDIntrinsicID intrinsicId,`
`1924`	`1924`	`if ((op1->gtFlags & GTF_SIDE_EFFECT) != 0)`
`1925`	`1925`	`{`
`1926`	`1926`	`op1LclNum = lvaGrabTemp(true DEBUGARG("SIMD Min/Max"));`
`1927`		`- dupOp1 = gtNewLclvNode(op1LclNum, op1->TypeGet());`
`1928`	`1927`	`lvaSetStruct(op1LclNum, typeHnd, false);`
	`1928`	`+ dupOp1 = gtNewLclvNode(op1LclNum, op1->TypeGet());`
`1929`	`1929`	`op1Assign = gtNewTempAssign(op1LclNum, op1);`
`1930`	`1930`	`op1 = gtNewLclvNode(op1LclNum, op1->TypeGet());`
`1931`	`1931`	`}`
`@@ -1937,8 +1937,8 @@ GenTree* Compiler::impSIMDMinMax(SIMDIntrinsicID intrinsicId,`
`1937`	`1937`	`if ((op2->gtFlags & GTF_SIDE_EFFECT) != 0)`
`1938`	`1938`	`{`
`1939`	`1939`	`op2LclNum = lvaGrabTemp(true DEBUGARG("SIMD Min/Max"));`
`1940`		`- dupOp2 = gtNewLclvNode(op2LclNum, op2->TypeGet());`
`1941`	`1940`	`lvaSetStruct(op2LclNum, typeHnd, false);`
	`1941`	`+ dupOp2 = gtNewLclvNode(op2LclNum, op2->TypeGet());`
`1942`	`1942`	`op2Assign = gtNewTempAssign(op2LclNum, op2);`
`1943`	`1943`	`op2 = gtNewLclvNode(op2LclNum, op2->TypeGet());`
`1944`	`1944`	`}`