Fix test returning 100 unconditionally (#94146)

gbalykov · web-flow · commit 7420ee78b7fc · 2023-10-30T10:53:41.000+01:00
Xunit error XUW1002: Tests should not unconditionally return 100. Convert to a void return.
diff --git a/src/tests/JIT/opt/RedundantBranch/RedundantBranchUnsigned2.cs b/src/tests/JIT/opt/RedundantBranch/RedundantBranchUnsigned2.cs
@@ -9,7 +9,7 @@
 public class RedundantBranchUnsigned2
 {
     [Fact]
-    public static int TestEntryPoint()
+    public static void TestEntryPoint()
     {
         int[] arr1 = new int[2];
         Test_Span1(arr1, -1);
@@ -37,7 +37,6 @@ public static int TestEntryPoint()
 
         // Should not throw NRE
         Test_Array(arr3, -1);
-        return 100;
     }
 
     private static void Throws<T>(Action action) where T : Exception

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`public class RedundantBranchUnsigned2`
`10`	`10`	`{`
`11`	`11`	`[Fact]`
`12`		`- public static int TestEntryPoint()`
	`12`	`+ public static void TestEntryPoint()`
`13`	`13`	`{`
`14`	`14`	`int[] arr1 = new int[2];`
`15`	`15`	`Test_Span1(arr1, -1);`
`@@ -37,7 +37,6 @@ public static int TestEntryPoint()`
`37`	`37`
`38`	`38`	`// Should not throw NRE`
`39`	`39`	`Test_Array(arr3, -1);`
`40`		`- return 100;`
`41`	`40`	`}`
`42`	`41`
`43`	`42`	`private static void Throws<T>(Action action) where T : Exception`