ConfigXmlReader is an IDisposable; Dispose it (#103163)

omajid · web-flow · commit 778b3ed3106c · 2024-06-13T09:18:22.000-04:00
This was flagged by a static analysis tool. Is this necessary? Is this
safe to do?
diff --git a/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/AppSettingsSection.cs b/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/AppSettingsSection.cs
@@ -127,7 +127,7 @@ protected internal override void DeserializeElement(XmlReader reader, bool seria
                 }
             }
 
-            ConfigXmlReader internalReader = new ConfigXmlReader(rawXml, sourceFileFullPath, lineOffset);
+            using ConfigXmlReader internalReader = new ConfigXmlReader(rawXml, sourceFileFullPath, lineOffset);
             internalReader.Read();
 
             if (internalReader.MoveToNextAttribute())

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ protected internal override void DeserializeElement(XmlReader reader, bool seria`
`127`	`127`	`}`
`128`	`128`	`}`
`129`	`129`
`130`		`- ConfigXmlReader internalReader = new ConfigXmlReader(rawXml, sourceFileFullPath, lineOffset);`
	`130`	`+ using ConfigXmlReader internalReader = new ConfigXmlReader(rawXml, sourceFileFullPath, lineOffset);`
`131`	`131`	`internalReader.Read();`
`132`	`132`
`133`	`133`	`if (internalReader.MoveToNextAttribute())`