fixup! Improve platform detection for tests

rzikm · rzikm · commit 8656a0ab1711 · 2022-03-02T11:57:46.000+01:00
diff --git a/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamCertificateTrustTests.cs b/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamCertificateTrustTests.cs
@@ -91,6 +91,7 @@ await TestConfiguration.WhenAllOrAnyFailedWithTimeout(
         }
 
         [ConditionalFact(nameof(SupportsSendingCustomCANamesInTls))]
+        [PlatformSpecific(TestPlatforms.Windows)]
         public void SslStream_SendCertificateTrust_CertificateCollection_ThrowsOnWindows()
         {
             (X509Certificate2 certificate, X509Certificate2Collection caCerts) = TestHelper.GenerateCertificates(nameof(SslStream_SendCertificateTrust_CertificateCollection));
@@ -99,7 +100,7 @@ public void SslStream_SendCertificateTrust_CertificateCollection_ThrowsOnWindows
         }
 
         [ConditionalFact(nameof(DoesNotSupportSendingCustomCANamesInTls))]
-        [SkipOnPlatform(TestPlatform.Windows)]
+        [SkipOnPlatform(TestPlatforms.Windows, "Windows tested separately")]
         public void SslStream_SendCertificateTrust_ThrowsOnUnsupportedPlatform()
         {
             (X509Certificate2 certificate, X509Certificate2Collection caCerts) = TestHelper.GenerateCertificates(nameof(SslStream_SendCertificateTrust_CertificateCollection));

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,7 @@ await TestConfiguration.WhenAllOrAnyFailedWithTimeout(`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`[ConditionalFact(nameof(SupportsSendingCustomCANamesInTls))]`
	`94`	`+ [PlatformSpecific(TestPlatforms.Windows)]`
`94`	`95`	`public void SslStream_SendCertificateTrust_CertificateCollection_ThrowsOnWindows()`
`95`	`96`	`{`
`96`	`97`	`(X509Certificate2 certificate, X509Certificate2Collection caCerts) = TestHelper.GenerateCertificates(nameof(SslStream_SendCertificateTrust_CertificateCollection));`
`@@ -99,7 +100,7 @@ public void SslStream_SendCertificateTrust_CertificateCollection_ThrowsOnWindows`
`99`	`100`	`}`
`100`	`101`
`101`	`102`	`[ConditionalFact(nameof(DoesNotSupportSendingCustomCANamesInTls))]`
`102`		`- [SkipOnPlatform(TestPlatform.Windows)]`
	`103`	`+ [SkipOnPlatform(TestPlatforms.Windows, "Windows tested separately")]`
`103`	`104`	`public void SslStream_SendCertificateTrust_ThrowsOnUnsupportedPlatform()`
`104`	`105`	`{`
`105`	`106`	`(X509Certificate2 certificate, X509Certificate2Collection caCerts) = TestHelper.GenerateCertificates(nameof(SslStream_SendCertificateTrust_CertificateCollection));`