Fix name to be INTERP_SIMD_INTRINSIC_V128_INSTANCE_EQUALS_R8

Author: tannergooding

src/mono/browser/runtime/jiterpreter-trace-generator.ts

@@ -3748,33 +3748,6 @@ function emit_simd_3 (builder: WasmBuilder, ip: MintOpcodePtr, index: SimdIntrin
                 builder.appendU8(WasmOpcode.i32_eqz);
             append_stloc_tail(builder, getArgU16(ip, 1), WasmOpcode.i32_store);
             return true;
-        case SimdIntrinsic3.V128_R4_FLOAT_EQUALITY:
-        case SimdIntrinsic3.V128_R8_FLOAT_EQUALITY: {
-            /*
-            Vector128<T> result = Vector128.Equals(lhs, rhs) | ~(Vector128.Equals(lhs, lhs) | Vector128.Equals(rhs, rhs));
-            return result.AsInt32() == Vector128<int>.AllBitsSet;
-            */
-            const isR8 = index === SimdIntrinsic3.V128_R8_FLOAT_EQUALITY,
-                eqOpcode = isR8 ? WasmSimdOpcode.f64x2_eq : WasmSimdOpcode.f32x4_eq;
-            builder.local("pLocals");
-            append_ldloc(builder, getArgU16(ip, 2), WasmOpcode.PREFIX_simd, WasmSimdOpcode.v128_load);
-            builder.local("math_lhs128", WasmOpcode.tee_local);
-            append_ldloc(builder, getArgU16(ip, 3), WasmOpcode.PREFIX_simd, WasmSimdOpcode.v128_load);
-            builder.local("math_rhs128", WasmOpcode.tee_local);
-            builder.appendSimd(eqOpcode);
-            builder.local("math_lhs128");
-            builder.local("math_lhs128");
-            builder.appendSimd(eqOpcode);
-            builder.local("math_rhs128");
-            builder.local("math_rhs128");
-            builder.appendSimd(eqOpcode);
-            builder.appendSimd(WasmSimdOpcode.v128_or);
-            builder.appendSimd(WasmSimdOpcode.v128_not);
-            builder.appendSimd(WasmSimdOpcode.v128_or);
-            builder.appendSimd(isR8 ? WasmSimdOpcode.i64x2_all_true : WasmSimdOpcode.i32x4_all_true);
-            append_stloc_tail(builder, getArgU16(ip, 1), WasmOpcode.i32_store);
-            return true;
-        }
         case SimdIntrinsic3.V128_I1_SHUFFLE: {
             // Detect a constant indices vector and turn it into a const. This allows
             //  v8 to use a more optimized implementation of the swizzle opcode

src/mono/mono/mini/interp/interp-simd-intrins.def

@@ -61,8 +61,8 @@ INTERP_SIMD_INTRINSIC_P_PP (INTERP_SIMD_INTRINSIC_V128_BITWISE_INEQUALITY, inter
 INTERP_SIMD_INTRINSIC_P_PP (INTERP_SIMD_INTRINSIC_V128_INSTANCE_EQUALS_R4, interp_v128_instance_equals_r4, -1)
 INTERP_SIMD_INTRINSIC_P_PP (INTERP_SIMD_INTRINSIC_V2_INSTANCE_EQUALS_R4, interp_v2_instance_equals_r4, -1)
 INTERP_SIMD_INTRINSIC_P_PP (INTERP_SIMD_INTRINSIC_V3_INSTANCE_EQUALS_R4, interp_v3_instance_equals_r4, -1)
-INTERP_SIMD_INTRINSIC_P_PP (INTERP_SIMD_INTRINSIC_V128_INSTANCE_EQUALS_R4, interp_v128_instance_equals_r8, -1)
-INTERP_SIMD_INTRINSIC_P_PP (INTERP_SIMD_INTRINSIC_V128_INSTANCE_EQUALS_BITIWSE, interp_v128_instance_equals_bitwise, -1)
+INTERP_SIMD_INTRINSIC_P_PP (INTERP_SIMD_INTRINSIC_V128_INSTANCE_EQUALS_R8, interp_v128_instance_equals_r8, -1)
+INTERP_SIMD_INTRINSIC_P_PP (INTERP_SIMD_INTRINSIC_V128_INSTANCE_EQUALS_BITWISE, interp_v128_instance_equals_bitwise, -1)
 
 INTERP_SIMD_INTRINSIC_P_PP (INTERP_SIMD_INTRINSIC_V128_EXCLUSIVE_OR, interp_v128_op_exclusive_or, 81)
 

src/mono/mono/mini/interp/interp-simd.c

@@ -197,7 +197,7 @@ interp_v128_op_bitwise_inequality (gpointer res, gpointer v1, gpointer v2)
 static void
 interp_v128_instance_equals_r4 (gpointer res, gpointer v1, gpointer v2)
 {
-	v128_r4 v1_cast = *(*(v128_r4**))v1;
+	v128_r4 v1_cast = **(v128_r4**)v1;
 	v128_r4 v2_cast = *(v128_r4*)v2;
 	v128_r4 result = (v1_cast == v2_cast) | ~((v1_cast == v1_cast) | (v2_cast == v2_cast));
 	memset (&v1_cast, 0xff, SIZEOF_V128);
@@ -235,7 +235,7 @@ interp_v3_instance_equals_r4 (gpointer res, gpointer v1, gpointer v2)
 static void
 interp_v128_instance_equals_r8 (gpointer res, gpointer v1, gpointer v2)
 {
-	v128_r8 v1_cast = *(*(v128_r8**))v1;
+	v128_r8 v1_cast = **(v128_r8**)v1;
 	v128_r8 v2_cast = *(v128_r8*)v2;
 	v128_r8 result = (v1_cast == v2_cast) | ~((v1_cast == v1_cast) | (v2_cast == v2_cast));
 	memset (&v1_cast, 0xff, SIZEOF_V128);