Optimize Options Source Gen when no need to run (#93481)

github-actions[bot] · tarekgh · web-flow · commit ae26d3e6dabe · 2023-10-13T17:31:33.000-06:00
Co-authored-by: Tarek Mahmoud Sayed &lt;tarekms@microsoft.com&gt;
diff --git a/src/libraries/Microsoft.Extensions.Options/gen/Generator.cs b/src/libraries/Microsoft.Extensions.Options/gen/Generator.cs
@@ -32,6 +32,11 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
 
         private static void HandleAnnotatedTypes(Compilation compilation, ImmutableArray<(TypeDeclarationSyntax? TypeSyntax, SemanticModel SemanticModel)> types, SourceProductionContext context)
         {
+            if (types.Length == 0)
+            {
+                return;
+            }
+
             if (!SymbolLoader.TryLoad(compilation, out var symbolHolder))
             {
                 // Not eligible compilation

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,11 @@ public void Initialize(IncrementalGeneratorInitializationContext context)`
`32`	`32`
`33`	`33`	`private static void HandleAnnotatedTypes(Compilation compilation, ImmutableArray<(TypeDeclarationSyntax? TypeSyntax, SemanticModel SemanticModel)> types, SourceProductionContext context)`
`34`	`34`	`{`
	`35`	`+ if (types.Length == 0)`
	`36`	`+ {`
	`37`	`+ return;`
	`38`	`+ }`
	`39`	`+`
`35`	`40`	`if (!SymbolLoader.TryLoad(compilation, out var symbolHolder))`
`36`	`41`	`{`
`37`	`42`	`// Not eligible compilation`