Skip to content

Commit b898b27

Browse files
committedApr 24, 2024
Fix Array_CreateInstance case
The PInvoke logic and the CheckAndReportRequires logic should not be needed for this intrinsic, and the old shared HandleCallAction would go to the default case that sets the return value to Top and returns false. Now this instead returns true and lets the shared return value logic kick in.
1 parent 69017ea commit b898b27

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/HandleCallAction.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,8 @@ private partial bool TryHandleIntrinsic (
218218
// We could try to analyze if the type is known, but for now making sure this works for canonical arrays is enough.
219219
TypeDesc canonArrayType = _reflectionMarker.Factory.TypeSystemContext.CanonType.MakeArrayType();
220220
_reflectionMarker.MarkType(_diagnosticContext.Origin, canonArrayType, "Array.CreateInstance was called");
221-
goto case IntrinsicId.None;
222221
}
222+
break;
223223

224224
//
225225
// System.Enum

0 commit comments

Comments
 (0)
Please sign in to comment.