Skip to content

Commit b9969dd

Browse files
Copilotstephentoubdanmoseley
authored
Update [GeneratedRegex] analyzer/fixer for partial properties (#120099)
--------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> Co-authored-by: Dan Moseley <danmose@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
1 parent afd2624 commit b9969dd

File tree

4 files changed

+563
-258
lines changed

4 files changed

+563
-258
lines changed

.github/copilot-instructions.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
You MUST make your best effort to ensure your changes satisfy those criteria before committing. If for any reason you were unable to build or test the changes, you MUST report that. You MUST NOT claim success unless all builds and tests pass as described above.
44

5+
Do not complete without checking the relevant code builds and relevant tests still pass after the last edits you make. Do not simply assume that your changes fix test failures you see, actually build and run those tests again to confirm.
6+
57
You MUST refer to the [Building & Testing in dotnet/runtime](#building--testing-in-dotnetruntime) instructions and use the commands and approaches specified there before attempting your own suggestions.
68

79
You MUST follow all code-formatting and naming conventions defined in [`.editorconfig`](/.editorconfig).
@@ -187,6 +189,8 @@ From the repository root:
187189
- [Build Libraries](/docs/workflow/building/libraries/README.md)
188190
- [Testing Libraries](/docs/workflow/testing/libraries/testing.md)
189191

192+
When working on changes limited to a specific library, do not complete without at least running all tests for that library and confirming they pass. For example if you are working within "System.Text.RegularExpressions" then make sure after your last edits that all the test libraries under `src\libraries\System.Text.RegularExpressions\tests` pass. It is OK to filter to relevant specific tests during your work, but before returning, ensure that, at least, ALL tests for the library do pass.
193+
190194
### 5.1. How To: Identify Affected Libraries
191195

192196
For each changed file under `src/libraries/`, find the matching library and its test project(s).

0 commit comments

Comments
 (0)