Optimize relocation counting in DehydratedDataNode.GetData (#103202)

filipnavara · web-flow · commit c1cebefa8b05 · 2024-06-10T06:42:42.000+02:00
diff --git a/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/DehydratedDataNode.cs b/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/DehydratedDataNode.cs
@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Runtime.InteropServices;
 
 using Internal.Runtime;
 using Internal.Text;
@@ -74,8 +75,7 @@ public override ObjectData GetData(NodeFactory factory, bool relocsOnly = false)
                     ISymbolNode target = reloc.Target;
                     if (target is ISymbolNodeWithLinkage withLinkage)
                         target = withLinkage.NodeForLinkage(factory);
-                    relocOccurences.TryGetValue(target, out int num);
-                    relocOccurences[target] = ++num;
+                    CollectionsMarshal.GetValueRefOrAddDefault(relocOccurences, target, out _)++;
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`
`4`	`4`	`using System;`
`5`	`5`	`using System.Collections.Generic;`
	`6`	`+using System.Runtime.InteropServices;`
`6`	`7`
`7`	`8`	`using Internal.Runtime;`
`8`	`9`	`using Internal.Text;`
`@@ -74,8 +75,7 @@ public override ObjectData GetData(NodeFactory factory, bool relocsOnly = false)`
`74`	`75`	`ISymbolNode target = reloc.Target;`
`75`	`76`	`if (target is ISymbolNodeWithLinkage withLinkage)`
`76`	`77`	`target = withLinkage.NodeForLinkage(factory);`
`77`		`- relocOccurences.TryGetValue(target, out int num);`
`78`		`- relocOccurences[target] = ++num;`
	`78`	`+ CollectionsMarshal.GetValueRefOrAddDefault(relocOccurences, target, out _)++;`
`79`	`79`	`}`
`80`	`80`	`}`
`81`	`81`