Encode UserName value in UriBuilder (Issue #74662) (#74953)

* Update UriBuilder.cs

* Adding check to Password

* Adding Unit Tests

* Update src/libraries/System.Private.Uri/src/System/UriBuilder.cs

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>

* Revising location of EncodeUserInfo to ToString()

* Update src/libraries/System.Private.Uri/tests/FunctionalTests/UriBuilderTests.cs

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>

Author: cdbullard

src/libraries/System.Private.Uri/src/System/UriBuilder.cs

@@ -255,6 +255,24 @@ public Uri Uri
 
         public override int GetHashCode() => Uri.GetHashCode();
 
+        private static string EncodeUserInfo(string input)
+        {
+            // The following characters ("/" / "\" / "?" / "#" / "@") are from the gen-delims group.
+            // We have to escape them to avoid corrupting the rest of the Uri string.
+            // Other characters like spaces or non-ASCII will be escaped by Uri, we can ignore them here.
+            if (input.AsSpan().IndexOfAny(@"/\?#@") < 0)
+            {
+                return input;
+            }
+
+            return input
+                .Replace("/", "%2F", StringComparison.Ordinal)
+                .Replace(@"\", "%5C", StringComparison.Ordinal)
+                .Replace("?", "%3F", StringComparison.Ordinal)
+                .Replace("#", "%23", StringComparison.Ordinal)
+                .Replace("@", "%40", StringComparison.Ordinal);
+        }
+
         private void SetFieldsFromUri()
         {
             Debug.Assert(_uri is not null);
@@ -315,12 +333,12 @@ public override string ToString()
                 vsb.Append(schemeDelimiter);
             }
 
-            string username = UserName;
+            string username = EncodeUserInfo(UserName);
             if (username.Length != 0)
             {
                 vsb.Append(username);
 
-                string password = Password;
+                string password = EncodeUserInfo(Password);
                 if (password.Length != 0)
                 {
                     vsb.Append(':');

src/libraries/System.Private.Uri/tests/FunctionalTests/UriBuilderTests.cs

@@ -385,6 +385,22 @@ public void ToString_Invalid()
             Assert.Throws<UriFormatException>(() => uriBuilder.ToString()); // Uri has a password but no username
         }
 
+        [Theory]
+        [InlineData(@"user/\?#@name", "", "http://user%2F%5C%3F%23%40name@localhost/")]
+        [InlineData(@"user/\?#@name", @"pass/\?#@word", "http://user%2F%5C%3F%23%40name:pass%2F%5C%3F%23%40word@localhost/")]
+        public void ToString_EncodingUserInfo(string username, string password, string expectedToString)
+        {
+            var uriBuilder = new UriBuilder
+            {
+                UserName = username,
+                Password = password
+            };
+
+            Assert.Equal(expectedToString, uriBuilder.ToString());
+            Assert.Equal(username, uriBuilder.UserName);
+            Assert.Equal(password, uriBuilder.Password);
+        }
+
         private static void VerifyUriBuilder(UriBuilder uriBuilder, string scheme, string userName, string password, string host, int port, string path, string query, string fragment)
         {
             Assert.Equal(scheme, uriBuilder.Scheme);