Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] move console proxy from runtime code into test-main #101169

Open
pavelsavara opened this issue Apr 17, 2024 · 3 comments
Open

[browser] move console proxy from runtime code into test-main #101169

pavelsavara opened this issue Apr 17, 2024 · 3 comments
Assignees
@pavelsavara @maraf @ilonatommy
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Milestone
Future

Comments

@pavelsavara
Copy link
Member

  • after we know how to inject it via dev server
  • chrome driver is probably forwarding enough console to be able to skip it completely
  • geckodriver is not forwarding any console logs (maybe this is configuration issue)
    • for that reason, some of the messages need to be duplicated in test-main, only after the proxy was already setup
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Apr 17, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 17, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara modified the milestones: 9.0.0, Future May 15, 2024
@ilonatommy
Copy link
Member

After #109069 we don't use test-main anymore. Can we close it?

@pavelsavara
Copy link
Member Author

We still use test-main to run normal library unit tests. And this issue is about forwarding the console log, which FF doesn't do with geckodriver. So I think we can't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavelsavara pavelsavara

@maraf maraf

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@pavelsavara @maraf @ilonatommy