Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Linux/x64: 1 Regression on 4/30/2024 10:57:18 AM #101991

Closed
performanceautofiler bot opened this issue May 7, 2024 · 2 comments · Fixed by #103714
Closed

[Perf] Linux/x64: 1 Regression on 4/30/2024 10:57:18 AM #101991

performanceautofiler bot opened this issue May 7, 2024 · 2 comments · Fixed by #103714
Assignees
@rzikm
Labels
arch-x64 area-System.Net.Http os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
9.0.0

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented May 7, 2024 •
edited
Loading

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline aab8803eac4111a711b6eb65242ee8a5b14fa411
Compare 017593d90781d797df8b2241f6d1f83c236c442b
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Net.Primitives.Tests.CredentialCacheTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
308.46 ns 358.40 ns 1.16 0.02 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Net.Primitives.Tests.CredentialCacheTests*'

System.Net.Primitives.Tests.CredentialCacheTests.GetCredential_Uri(uriString: "http://name5", uriCount: 10)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels May 7, 2024
@performanceautofiler performanceautofiler bot mentioned this issue May 7, 2024
Closed
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues May 7, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 7, 2024
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels May 7, 2024
@DrewScoggins
Copy link
Member

Related to #101053

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 9, 2024
@antonfirsov antonfirsov removed the untriaged New issue has not been triaged by the area owner label May 15, 2024
@antonfirsov antonfirsov added this to the 9.0.0 milestone May 15, 2024
@rzikm rzikm mentioned this issue Jun 19, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzikm rzikm

Labels
arch-x64 area-System.Net.Http os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Improve perf of CredentialCache.GetCredential rzikm/dotnet-runtime
5 participants
@vcsjones @antonfirsov @DrewScoggins @jeffschwMSFT @rzikm