Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build is broken for main due to conflicting PRs #102930

Closed
stephentoub opened this issue May 31, 2024 · 2 comments · Fixed by #102931
Closed

Build is broken for main due to conflicting PRs #102930

stephentoub opened this issue May 31, 2024 · 2 comments · Fixed by #102931
Labels
area-System.Runtime.InteropServices

Comments

@stephentoub
Copy link
Member

#102636 and #102034 got merged in parallel and conflict. The latter made GenericCache generic and the former uses the non-generic.

D:\repos\runtime\src\coreclr\System.Private.CoreLib\src\System\RuntimeType.CoreCLR.cs(3970,17): error CS0305: Using the generic type 'GenericCache<TKey, TValue>' requires 2 type arguments [D:\repos\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.cspro
j]
D:\repos\runtime\src\coreclr\System.Private.CoreLib\src\System\RuntimeType.CoreCLR.cs(3972,29): error CS0122: 'RuntimeType.ActivatorCache.ActivatorCache(RuntimeType)' is inaccessible due to its protection level [D:\repos\runtime\src\coreclr\System.Private.CoreLib\Syste
m.Private.CoreLib.csproj]
D:\repos\runtime\src\coreclr\System.Private.CoreLib\src\System\RuntimeType.CoreCLR.cs(3973,17): error CS0305: Using the generic type 'GenericCache<TKey, TValue>' requires 2 type arguments [D:\repos\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.cspro
j]

cc: @jkoritzinsky, @AaronRobinsonMSFT
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 31, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@stephentoub stephentoub added area-System.Runtime.InteropServices and removed area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels May 31, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky jkoritzinsky mentioned this issue May 31, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime.InteropServices
Projects
AppModel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update new ActivatorCache usage to the new API model. jkoritzinsky/runtime
1 participant
@stephentoub