-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Reconsider block weight propagation in loop cloning #103001
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Comments
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 3, 2024
dotnet-policy-service
bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Jun 3, 2024
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
JulieLeeMSFT
removed
the
untriaged
New issue has not been triaged by the area owner
label
Jun 3, 2024
JulieLeeMSFT
added
the
Priority:2
Work that is important, but not critical for the release
label
Jun 3, 2024
cc @AndyAyersMS. |
amanasifkhalid
removed
the
Priority:2
Work that is important, but not critical for the release
label
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Part of #93020. As mentioned in #102897, the logic in
Compiler::optCloneLoops
for propagating block weights is probably wrong when we have weights derived from PGO data -- in particular, we shouldn't need to scale weights based on the loop's depth. Doing so likely breaks block weight consistency (which we aren't checking just yet this late in the JIT's phases, hence the lack of assert failures).The text was updated successfully, but these errors were encountered: