Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE Fortunes regression on Windows #103256

Open
sebastienros opened this issue Jun 10, 2024 · 2 comments
Open

TE Fortunes regression on Windows #103256

sebastienros opened this issue Jun 10, 2024 · 2 comments

Comments

@sebastienros
Copy link
Member

Only on Windows
Isolated to a single PR: Add three-stage enqueuer/dispatcher scheme to SocketAsyncEngine, ThreadPoolWorkQueue and ThreadPoolTypedWorkItemQueue

I see this regression was mentioned in the PR but I think it's better to create an issue to raise awareness and/or officially accepting it.

Regression in RPS
image

CPU has less usage (not a bad thing per se, compromise or correlation with loss of RPS)
image

Max TP items /s also lower
image

@eduardo-vp
@kouvel

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@stephentoub stephentoub added this to the 9.0.0 milestone Jun 13, 2024
@kouvel kouvel self-assigned this Aug 15, 2024
@kouvel
Copy link
Member

kouvel commented Aug 26, 2024

The change reduces excessive parallelization, which is not a bad thing. There can be some minor tradeoffs based on timing. Excessive parallelization can be beneficial for some situations, but typically it just adds to CPU time without any other perf benefit. Maybe there are other ways to recover the throughput regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants